-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix azure disk create failure due to sdk upgrade #67236
fix azure disk create failure due to sdk upgrade #67236
Conversation
FYI @weherdh |
@andyzhangx So PR #65846 did not fully fix the issue? |
What about the managed disk? Does this PR also fix that? Or we need separated issue and fix. |
managed disk don't need storage account, it won't have such issue. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
3 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue (batch tested with PRs 66984, 67236, 67216, 62721, 67106). If you want to cherry-pick this change to another branch, please follow the instructions here. |
This issue only happens on k8s version: 1.11.0 ~1.11.2
|
What this PR does / why we need it:
fix azure storage account creation failure, this happens only on unmanaged k8s cluster on Azure.
This bug is due to azure-sdk-for-go API change introduced in v1.11:
https://github.com/Azure/azure-sdk-for-go/blob/fbe7db0e3f9793ba3e5704efbab84f51436c136e/services/storage/mgmt/2017-10-01/storage/models.go#L381-L382
there is a new field
Kind
which is required, so any sdk upgrade from and old version would break the storage account creation since old code won't useKind
. I have filed an issue to azure-sdk-for-go: Azure/azure-sdk-for-go#2182Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #67234
Special notes for your reviewer:
Release note:
/kind bug
/sig azure
/assign @feiskyer
FYI @khenidak @brendandburns