Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix azure disk create failure due to sdk upgrade #67236

Merged

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 10, 2018

What this PR does / why we need it:
fix azure storage account creation failure, this happens only on unmanaged k8s cluster on Azure.

This bug is due to azure-sdk-for-go API change introduced in v1.11:
https://github.com/Azure/azure-sdk-for-go/blob/fbe7db0e3f9793ba3e5704efbab84f51436c136e/services/storage/mgmt/2017-10-01/storage/models.go#L381-L382

there is a new field Kind which is required, so any sdk upgrade from and old version would break the storage account creation since old code won't use Kind. I have filed an issue to azure-sdk-for-go: Azure/azure-sdk-for-go#2182
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #67234

Special notes for your reviewer:

Release note:

fix azure disk create failure due to sdk upgrade

/kind bug
/sig azure

/assign @feiskyer
FYI @khenidak @brendandburns

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. sig/azure size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2018
@andyzhangx
Copy link
Member Author

FYI @weherdh

@weherdh
Copy link

weherdh commented Aug 10, 2018

@andyzhangx So PR #65846 did not fully fix the issue?

@andyzhangx
Copy link
Member Author

@weherdh PR #65846 fixes the azure file creation issue, while this PR fixes azure unmanaged disk creation issue although fix is similar.

@weherdh
Copy link

weherdh commented Aug 10, 2018

What about the managed disk? Does this PR also fix that? Or we need separated issue and fix.

@andyzhangx
Copy link
Member Author

What about the managed disk? Does this PR also fix that? Or we need separated issue and fix.

managed disk don't need storage account, it won't have such issue.

@feiskyer
Copy link
Member

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 66984, 67236, 67216, 62721, 67106). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d427a23 into kubernetes:master Aug 11, 2018
k8s-github-robot pushed a commit that referenced this pull request Aug 16, 2018
…7236-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #67236: fix azure disk create failure due to sdk upgrade

Cherry pick of #67236 on release-1.11.

#67236: fix azure disk create failure due to sdk upgrade
@andyzhangx
Copy link
Member Author

This issue only happens on k8s version: 1.11.0 ~1.11.2
workaround:

  1. create a V2 storage account with Standard_LRS or Premium_LRS (depends on storageAccountType in azure file storage class)
  2. use azure file storage class:
---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: azurefile
provisioner: kubernetes.io/azure-file
parameters:
  storageAccount: EXISTING_STORAGE_ACCOUNT
  skuName: Standard_LRS  #available values: Standard_LRS, Standard_GRS, Standard_RAGRS, (and Premium_LRS are supported from k8s v1.13.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create azure disk PVC failed due to account creation failure
6 participants