Re-add pkg/generated/bindata.go #65985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/assign @thockin |
|
/retest |
|
/lgtm |
k8s-ci-robot
added
lgtm
|
/lgtm yes please! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, ixdy, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ixdy, Let's backport please! |
|
#66009 for cherrypick. |
|
Automatic merge from submit-queue (batch tested with PRs 65993, 65986, 65351, 65996, 65985). If you want to cherry-pick this change to another branch, please follow the instructions here. |
This was referenced Jul 10, 2018
k8s-github-robot
pushed a commit
that referenced
this pull request
Jul 11, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Don't delete pkg/generated/bindata.go in make clean **What this PR does / why we need it**: follow-up to #65985: `pkg/generated/bindata.go` has been re-added to the repo, so `make clean` shouldn't delete it, as doing so makes the tree dirty. This is mostly problematic for jobs which run `make clean` followed by `make quick-release` or `make release` (like our CI build job), since those won't regenerate `pkg/generated/bindata.go`, as they run builds inside the build container. **Release note**: ```release-note NONE ```
k8s-github-robot
pushed a commit
that referenced
this pull request
Jul 13, 2018
…65986-#65985-upstream-release-1.11 Automatic merge from submit-queue. Automated cherry pick of #65882: Add script to verify generated files #65986: verify-generated-files: ensure git tree is clean #65985: Don't gitignore pkg/generated/bindata.go Cherry pick of #65882 #65986 #65985 #66076 on release-1.11. #65882: Add script to verify generated files #65986: verify-generated-files: ensure git tree is clean #65985: Re-add pkg/generated/bindata.go #66076: Don't delete pkg/generated/bindata.go in make clean ```release-note Re-adds `pkg/generated/bindata.go` to the repository to allow some parts of k8s.io/kubernetes to be go-vendorable. ``` Fixes #65968.
|
/sig release |
k8s-ci-robot
added
the
sig/release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: I removed
pkg/generated/bindata.goin #62432 as it had drifted out-of-date and was automatically generated bymakeandbazel.This broke some downstream users who import
k8s.io/kubernetes.It's unclear whether the project intends for
k8s.io/kubernetesto be vendorable, as there are other generated files which are not saved in the repo, includingpkg/generated/openapi/zz_generated.openapi.goandtest/e2e/generated/bindata.go, butpkg/generated/bindata.goseems to be a core dependency for current uses.The new verify check added in #65882 will ensure that this file stays up-to-date.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):This partially addresses #65968. We also need to cherry-pick this to release-1.11.
Release note: