Graduate Quota configuration API to v1beta1 #66156

vikaschoudhary16 · 2018-07-13T11:06:55Z

Release note:

Quota admission configuration api graduated to v1beta1

/sig node
/sig scheduling
/cc @derekwaynecarr @deads2k @liggitt @sjenning @aveshagarwal @ravisantoshgudimetla @smarterclayton

ravisantoshgudimetla · 2018-07-16T14:50:23Z

@vikaschoudhary16 - Can you please look at the lint failures:

Do you want to modify e2e's to use beta version in a follow-up PR?

vikaschoudhary16 · 2018-07-17T10:21:29Z

@ravisantoshgudimetla golint should be happy now.

Do you want to modify e2e's to use beta version in a follow-up PR?

There is no existing e2e test which is using this api. Also quoting @aveshagarwal
#64645 (comment)

varying admission plugin config can not be passed to e2e tests, as that would require restarting the cluster whenever the config is changed.

Though i am still thinking how to add an e2e for this. Will create a different PR, if i figured it out. Meanwhile would like to know suggestions if got any.

k82cn · 2018-08-02T00:46:48Z

/status approved-for-milestone

k8s-github-robot · 2018-08-02T00:47:43Z

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@vikaschoudhary16

Pull Request Labels

sig/node sig/scheduling: Pull Request will be escalated to these SIGs if needed.
priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
kind/feature: New functionality.

Help

k82cn · 2018-08-02T05:28:16Z

LGTM overall :)

ravisantoshgudimetla · 2018-08-02T20:06:02Z

@vikaschoudhary16 The way I have done moving api from alpha to beta in the past is ensuring alpha versionexists while creating beta. This ensures people using alpha have some breathing space before switching to beta. Please take a look at https://github.com/kubernetes/community/blob/master/contributors/devel/api_changes.md, while the wording is not clear on removing alpha version, it explicitly tells to copy https://github.com/kubernetes/community/blob/master/contributors/devel/api_changes.md#making-a-new-api-version

bsalamat · 2018-08-02T20:09:13Z

plugin/pkg/admission/resourcequota/apis/resourcequota/v1beta1/BUILD

@@ -16,7 +16,7 @@ go_library(
        "zz_generated.deepcopy.go",
        "zz_generated.defaults.go",
    ],
-    importpath = "k8s.io/kubernetes/plugin/pkg/admission/resourcequota/apis/resourcequota/v1alpha1",


Please do not delete (rename) v1alpha1 files. If we deleted these files, v1alpha1 APIs would stop working in the next K8s release.

ravisantoshgudimetla · 2018-08-03T11:46:02Z

plugin/pkg/admission/resourcequota/BUILD

@@ -28,7 +28,7 @@ go_library(
        "//pkg/util/workqueue/prometheus:go_default_library",
        "//plugin/pkg/admission/resourcequota/apis/resourcequota:go_default_library",
        "//plugin/pkg/admission/resourcequota/apis/resourcequota/install:go_default_library",
-        "//plugin/pkg/admission/resourcequota/apis/resourcequota/v1alpha1:go_default_library",


Shouldn't we have this line?

ravisantoshgudimetla · 2018-08-03T11:56:07Z

plugin/pkg/admission/resourcequota/apis/resourcequota/install/install.go

@@ -22,12 +22,12 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 	resourcequotaapi "k8s.io/kubernetes/plugin/pkg/admission/resourcequota/apis/resourcequota"
-	resourcequotav1alpha1 "k8s.io/kubernetes/plugin/pkg/admission/resourcequota/apis/resourcequota/v1alpha1"


I think, we should have this line as well.

ravisantoshgudimetla · 2018-08-03T12:02:56Z

plugin/pkg/admission/resourcequota/apis/resourcequota/install/install.go

 )

 // Install registers the API group and adds types to a scheme
 func Install(scheme *runtime.Scheme) {
 	utilruntime.Must(resourcequotaapi.AddToScheme(scheme))
-	utilruntime.Must(resourcequotav1alpha1.AddToScheme(scheme))


I think you should have this version but setting the default version to beta in subsequent line which you are doing should be good enough.

actually both should be added in subsequent line in priority order. will update, Thanks!

bsalamat

/lgtm

Thanks, @vikaschoudhary16!

k82cn · 2018-08-04T10:33:19Z

/lgtm , thanks :)

vikaschoudhary16 · 2018-08-05T06:01:06Z

/assign @deads2k for approval.

deads2k · 2018-08-06T12:37:12Z

/approve

k8s-ci-robot · 2018-08-06T12:37:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, deads2k, k82cn, vikaschoudhary16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~hack/OWNERS~~ [deads2k]
~~plugin/pkg/admission/OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-github-robot · 2018-08-06T14:13:19Z

Automatic merge from submit-queue (batch tested with PRs 66351, 66883, 66156). If you want to cherry-pick this change to another branch, please follow the instructions here.

k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 13, 2018

k8s-ci-robot requested review from aveshagarwal and deads2k July 13, 2018 11:06

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jul 13, 2018

k8s-ci-robot requested review from derekwaynecarr, liggitt, ravisantoshgudimetla, sjenning and smarterclayton July 13, 2018 11:06

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 13, 2018

vikaschoudhary16 force-pushed the quota-api-v1beta1 branch from 3c1aec1 to 4ef4295 Compare July 17, 2018 09:47

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 17, 2018

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2018

bsalamat added this to the v1.12 milestone Jul 25, 2018

k8s-github-robot added the milestone/incomplete-labels label Jul 25, 2018

vikaschoudhary16 force-pushed the quota-api-v1beta1 branch from 4ef4295 to e4c0680 Compare July 26, 2018 12:44

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2018

vikaschoudhary16 mentioned this pull request Jul 26, 2018

[Umbrella Issue] Quota Support For Priority-Class Work Tracker #66673

Closed

7 tasks

vikaschoudhary16 force-pushed the quota-api-v1beta1 branch 2 times, most recently from 19f96d2 to 2edb9d1 Compare July 27, 2018 05:29

k8s-github-robot added milestone/removed and removed milestone/incomplete-labels labels Jul 29, 2018

k8s-github-robot removed this from the v1.12 milestone Jul 29, 2018

vikaschoudhary16 force-pushed the quota-api-v1beta1 branch from 2edb9d1 to bfaf8d2 Compare July 30, 2018 09:39

bsalamat added this to the v1.12 milestone Jul 30, 2018

bsalamat added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 30, 2018

k8s-github-robot added milestone/needs-approval and removed milestone/removed labels Jul 30, 2018

k8s-ci-robot added the status/approved-for-milestone label Aug 2, 2018

k8s-github-robot removed the milestone/needs-approval label Aug 2, 2018

bsalamat reviewed Aug 2, 2018

View reviewed changes

Graduate quota configuration api to v1beta1

1708ee4

vikaschoudhary16 force-pushed the quota-api-v1beta1 branch from bfaf8d2 to afd71f6 Compare August 3, 2018 06:25

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2018

ravisantoshgudimetla reviewed Aug 3, 2018

View reviewed changes

Update api version references

5e384d4

vikaschoudhary16 force-pushed the quota-api-v1beta1 branch from afd71f6 to 5e384d4 Compare August 3, 2018 15:08

bsalamat approved these changes Aug 3, 2018

View reviewed changes

k8s-ci-robot assigned bsalamat Aug 3, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2018

k8s-github-robot merged commit d4d0276 into kubernetes:master Aug 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Graduate Quota configuration API to v1beta1 #66156

Graduate Quota configuration API to v1beta1 #66156

vikaschoudhary16 commented Jul 13, 2018 •

edited

Loading

ravisantoshgudimetla commented Jul 16, 2018

vikaschoudhary16 commented Jul 17, 2018

k82cn commented Aug 2, 2018

k8s-github-robot commented Aug 2, 2018

k82cn commented Aug 2, 2018

ravisantoshgudimetla commented Aug 2, 2018

bsalamat Aug 2, 2018

ravisantoshgudimetla Aug 3, 2018

ravisantoshgudimetla Aug 3, 2018

ravisantoshgudimetla Aug 3, 2018

vikaschoudhary16 Aug 3, 2018

bsalamat left a comment

k82cn commented Aug 4, 2018

vikaschoudhary16 commented Aug 5, 2018

deads2k commented Aug 6, 2018

k8s-ci-robot commented Aug 6, 2018

k8s-github-robot commented Aug 6, 2018

Graduate Quota configuration API to v1beta1 #66156

Graduate Quota configuration API to v1beta1 #66156

Conversation

vikaschoudhary16 commented Jul 13, 2018 • edited Loading

ravisantoshgudimetla commented Jul 16, 2018

vikaschoudhary16 commented Jul 17, 2018

k82cn commented Aug 2, 2018

k8s-github-robot commented Aug 2, 2018

k82cn commented Aug 2, 2018

ravisantoshgudimetla commented Aug 2, 2018

bsalamat Aug 2, 2018

Choose a reason for hiding this comment

ravisantoshgudimetla Aug 3, 2018

Choose a reason for hiding this comment

ravisantoshgudimetla Aug 3, 2018

Choose a reason for hiding this comment

ravisantoshgudimetla Aug 3, 2018

Choose a reason for hiding this comment

vikaschoudhary16 Aug 3, 2018

Choose a reason for hiding this comment

bsalamat left a comment

Choose a reason for hiding this comment

k82cn commented Aug 4, 2018

vikaschoudhary16 commented Aug 5, 2018

deads2k commented Aug 6, 2018

k8s-ci-robot commented Aug 6, 2018

k8s-github-robot commented Aug 6, 2018

vikaschoudhary16 commented Jul 13, 2018 •

edited

Loading