Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rescheduler since scheduling DS pods by default scheduler is moving to beta #67687

Merged
merged 1 commit into from Aug 23, 2018
Merged

Conversation

Lion-Wei
Copy link

What this PR does / why we need it:

remove rescheduler since scheduling DS pods by default scheduler is moving to beta

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #64725

Special notes for your reviewer:

Release note:

Remove rescheduler since scheduling DS pods by default scheduler is moving to beta.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 22, 2018
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 22, 2018
@Lion-Wei
Copy link
Author

/cc @ravisantoshgudimetla @Huang-Wei
PTAL, thanks.

@k8s-ci-robot
Copy link
Contributor

@Lion-Wei: GitHub didn't allow me to request PR reviews from the following users: Huang-Wei.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ravisantoshgudimetla @Huang-Wei
PTAL, thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Lion-Wei

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2018
@ravisantoshgudimetla
Copy link
Contributor

ravisantoshgudimetla commented Aug 22, 2018

/assign @bsalamat @eparis @yujuhong @derekwaynecarr @ixdy - Can you please approve this? - This ensures rescheduler is removed from master. We don't need it anymore as scheduler is going to schedule DS pods.

cc @Huang-Wei

@ixdy
Copy link
Member

ixdy commented Aug 22, 2018

/approve

@Lion-Wei
Copy link
Author

@ravisantoshgudimetla Thanks.
/assign @bsalamat @eparis @yujuhong @derekwaynecarr
Can you please approve this? - This ensures rescheduler is removed from master. We don't need it anymore as scheduler is going to schedule DS pods.

@Huang-Wei
Copy link
Member

@Lion-Wei thanks for the PR. The changes look good to me.

BTW: it still needs approval from one owner of cluster/OWNERS:

  • eparis
  • jbeda
  • mikedanese
  • roberthbailey
  • zmerlynn

@eparis
Copy link
Contributor

eparis commented Aug 23, 2018

/approve

@derekwaynecarr
Copy link
Member

kubelet change is fine.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, eparis, ixdy, Lion-Wei, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@Huang-Wei
Copy link
Member

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d67a031 into kubernetes:master Aug 23, 2018
@k8s-ci-robot
Copy link
Contributor

@Lion-Wei: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gke 5ea138f link /test pull-kubernetes-e2e-gke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Lion-Wei
Copy link
Author

Thanks all. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove rescheduler once scheduling DS pods by default scheduler moves to beta.
10 participants