-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove rescheduler since scheduling DS pods by default scheduler is moving to beta #67687
remove rescheduler since scheduling DS pods by default scheduler is moving to beta #67687
Conversation
/cc @ravisantoshgudimetla @Huang-Wei |
@Lion-Wei: GitHub didn't allow me to request PR reviews from the following users: Huang-Wei. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Lion-Wei
/lgtm
/assign @bsalamat @eparis @yujuhong @derekwaynecarr @ixdy - Can you please approve this? - This ensures rescheduler is removed from master. We don't need it anymore as scheduler is going to schedule DS pods. cc @Huang-Wei |
/approve |
@ravisantoshgudimetla Thanks. |
@Lion-Wei thanks for the PR. The changes look good to me. BTW: it still needs approval from one owner of cluster/OWNERS:
|
/approve |
kubelet change is fine. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, eparis, ixdy, Lion-Wei, ravisantoshgudimetla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
@Lion-Wei: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks all. : ) |
What this PR does / why we need it:
remove rescheduler since scheduling DS pods by default scheduler is moving to beta
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #64725
Special notes for your reviewer:
Release note: