New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rescheduler since scheduling DS pods by default scheduler is moving to beta #67687

Merged
merged 1 commit into from Aug 23, 2018

Conversation

@Lion-Wei
Contributor

Lion-Wei commented Aug 22, 2018

What this PR does / why we need it:

remove rescheduler since scheduling DS pods by default scheduler is moving to beta

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #64725

Special notes for your reviewer:

Release note:

Remove rescheduler since scheduling DS pods by default scheduler is moving to beta.
@Lion-Wei

This comment has been minimized.

Show comment
Hide comment
@Lion-Wei

Lion-Wei Aug 22, 2018

Contributor

/cc @ravisantoshgudimetla @Huang-Wei
PTAL, thanks.

Contributor

Lion-Wei commented Aug 22, 2018

/cc @ravisantoshgudimetla @Huang-Wei
PTAL, thanks.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 22, 2018

Contributor

@Lion-Wei: GitHub didn't allow me to request PR reviews from the following users: Huang-Wei.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ravisantoshgudimetla @Huang-Wei
PTAL, thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Aug 22, 2018

@Lion-Wei: GitHub didn't allow me to request PR reviews from the following users: Huang-Wei.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ravisantoshgudimetla @Huang-Wei
PTAL, thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ravisantoshgudimetla

Thanks for the PR @Lion-Wei

/lgtm

@ravisantoshgudimetla

This comment has been minimized.

Show comment
Hide comment
@ravisantoshgudimetla

ravisantoshgudimetla Aug 22, 2018

Contributor

/assign @bsalamat @eparis @yujuhong @derekwaynecarr @ixdy - Can you please approve this? - This ensures rescheduler is removed from master. We don't need it anymore as scheduler is going to schedule DS pods.

cc @Huang-Wei

Contributor

ravisantoshgudimetla commented Aug 22, 2018

/assign @bsalamat @eparis @yujuhong @derekwaynecarr @ixdy - Can you please approve this? - This ensures rescheduler is removed from master. We don't need it anymore as scheduler is going to schedule DS pods.

cc @Huang-Wei

@ixdy

This comment has been minimized.

Show comment
Hide comment
@ixdy

ixdy Aug 22, 2018

Member

/approve

Member

ixdy commented Aug 22, 2018

/approve

@Lion-Wei

This comment has been minimized.

Show comment
Hide comment
@Lion-Wei

Lion-Wei Aug 23, 2018

Contributor

@ravisantoshgudimetla Thanks.
/assign @bsalamat @eparis @yujuhong @derekwaynecarr
Can you please approve this? - This ensures rescheduler is removed from master. We don't need it anymore as scheduler is going to schedule DS pods.

Contributor

Lion-Wei commented Aug 23, 2018

@ravisantoshgudimetla Thanks.
/assign @bsalamat @eparis @yujuhong @derekwaynecarr
Can you please approve this? - This ensures rescheduler is removed from master. We don't need it anymore as scheduler is going to schedule DS pods.

@Huang-Wei

This comment has been minimized.

Show comment
Hide comment
@Huang-Wei

Huang-Wei Aug 23, 2018

Member

@Lion-Wei thanks for the PR. The changes look good to me.

BTW: it still needs approval from one owner of cluster/OWNERS:

  • eparis
  • jbeda
  • mikedanese
  • roberthbailey
  • zmerlynn
Member

Huang-Wei commented Aug 23, 2018

@Lion-Wei thanks for the PR. The changes look good to me.

BTW: it still needs approval from one owner of cluster/OWNERS:

  • eparis
  • jbeda
  • mikedanese
  • roberthbailey
  • zmerlynn
@eparis

This comment has been minimized.

Show comment
Hide comment
@eparis

eparis Aug 23, 2018

Member

/approve

Member

eparis commented Aug 23, 2018

/approve

@derekwaynecarr

This comment has been minimized.

Show comment
Hide comment
@derekwaynecarr

derekwaynecarr Aug 23, 2018

Member

kubelet change is fine.

/approve

Member

derekwaynecarr commented Aug 23, 2018

kubelet change is fine.

/approve

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 23, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, eparis, ixdy, Lion-Wei, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, eparis, ixdy, Lion-Wei, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 23, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Aug 23, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@Huang-Wei

This comment has been minimized.

Show comment
Hide comment
@Huang-Wei

Huang-Wei Aug 23, 2018

Member

/retest

Member

Huang-Wei commented Aug 23, 2018

/retest

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 23, 2018

Contributor

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

Contributor

k8s-merge-robot commented Aug 23, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit d67a031 into kubernetes:master Aug 23, 2018

15 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
pull-kubernetes-e2e-gke Job triggered.
Details
pull-kubernetes-local-e2e-containerized Job triggered.
Details
cla/linuxfoundation Lion-Wei authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 23, 2018

Contributor

@Lion-Wei: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gke 5ea138f link /test pull-kubernetes-e2e-gke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Aug 23, 2018

@Lion-Wei: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gke 5ea138f link /test pull-kubernetes-e2e-gke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Lion-Wei

This comment has been minimized.

Show comment
Hide comment
@Lion-Wei

Lion-Wei Aug 24, 2018

Contributor

Thanks all. : )

Contributor

Lion-Wei commented Aug 24, 2018

Thanks all. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment