Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #67288: Immediate close the other half of the connection when #68041

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Automated cherry pick of #67288: Immediate close the other half of the connection when #68041

merged 1 commit into from
Oct 19, 2018

Conversation

tossmilestone
Copy link
Member

@tossmilestone tossmilestone commented Aug 30, 2018 •
edited

Cherry pick of #67288 on release-1.11.

#67288: Immediate close the other half of the connection when

Release note:

Immediately close the other side of the connection when proxying.

@MHBauer @tossmilestone
Immediate close the other half of the connection when proxying
1cbb599 
 - don't wait for the both sides of the connection to close on their
   own. If one closes there doesn't seem to be any point in continuing
   the other half.
 - for port-forward, this prevents the api-server and kubelet both
   waiting on the other with no result. Normally the connection
   eventually times out. This cleans up the connection appropriately.
 - add a log message on closing the connection that corresponds to
   opening the connection
@k8s-ci-robot
Copy link
Contributor

@tossmilestone:
This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.
To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.
The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 30, 2018
@tossmilestone
Copy link
Member Author

/assign @deads2k

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 31, 2018
@tossmilestone
Copy link
Member Author

/assign @liggitt @lavalamp @smarterclayton

@tossmilestone
Copy link
Member Author

/assign @foxish

@BenTheElder
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 21, 2018
@foxish
Copy link
Contributor

foxish commented Oct 3, 2018 •
edited

@tossmilestone, this needs lgtm and approval. Also, can you please write the release note in user-facing terms? i.e. what impact it will have.

@lavalamp
Copy link
Member

lavalamp commented Oct 3, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, tossmilestone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2018
@MHBauer
Copy link
Contributor

MHBauer commented Oct 8, 2018

@foxish is the patch release manager and is already assigned.
If the release note needs changing, does editing it in the original PR update all PRs or does it require each PR owner to update separately?

@MHBauer
Copy link
Contributor

MHBauer commented Oct 8, 2018

@foxish This isn't a user facing change. There should be nothing different. It changes how server components interact with each other.

@foxish foxish added this to the v1.11 milestone Oct 19, 2018
@foxish foxish added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 19, 2018
@foxish foxish added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit dc53ba3 into kubernetes:release-1.11 Oct 19, 2018
@mikebrow mikebrow mentioned this pull request Oct 25, 2018
Closed
@timchenxiaoyu timchenxiaoyu mentioned this pull request Nov 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@lavalamp lavalamp

@foxish foxish

@liggitt liggitt

@smarterclayton smarterclayton

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@tossmilestone @k8s-ci-robot @BenTheElder @foxish @lavalamp @MHBauer @liggitt @smarterclayton @deads2k