-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix UnmountDevice failure on Windows #68608
fix UnmountDevice failure on Windows #68608
Conversation
/test pull-kubernetes-cross |
65b45fc
to
8618762
Compare
/lgtm |
@jsafrane PTAL |
/test pull-kubernetes-kubemark-e2e-gce-big |
/approve |
8618762
to
a192f03
Compare
add comments fix test failure
a192f03
to
74f0102
Compare
/test pull-kubernetes-cross |
rebased, and I changed the test code a little @jsafrane PTAL |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, jsafrane, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…8608-upstream-release-1.9 Automated cherry pick of #68608: fix UnmountDevice failure on Windows
…8608-upstream-release-1.12 Automated cherry pick of #68608: fix UnmountDevice failure on Windows
…8608-upstream-release-1.10 Automated cherry pick of #68608: fix UnmountDevice failure on Windows
…8608-upstream-release-1.11 Automated cherry pick of #68608: fix UnmountDevice failure on Windows
What this PR does / why we need it:
fix UnmountDevice failure on Windows, root cause is
GetMountRefs
on windows is not correctly implemented.Error code is like following:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #68512
Special notes for your reviewer:
On Windows, there is no place to query all mount points like
/proc/mounts
on Linux, so I actually did an empty implementation forGetMountRefs
on Windows, which could skip the below error check:kubernetes/pkg/volume/util/operationexecutor/operation_generator.go
Lines 756 to 758 in 426ef9d
Release note:
/kind bug
/sig windows
@PatrickLang