Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #68608: fix UnmountDevice failure on Windows #69079

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Automated cherry pick of #68608: fix UnmountDevice failure on Windows #69079

merged 1 commit into from
Oct 4, 2018

Conversation

andyzhangx
Copy link
Member

Cherry pick of #68608 on release-1.11.

#68608: fix UnmountDevice failure on Windows

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2018
@andyzhangx
Copy link
Member Author

/assign @jsafrane

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-cross

@andyzhangx
fix UnmountDevice failure on Windows
c87374b 
add comments

fix test failure

fix another GetMountRefs func
@andyzhangx andyzhangx force-pushed the automated-cherry-pick-of-#68608-upstream-release-1.11 branch from cd00313 to c87374b Compare September 26, 2018 06:55
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-cross

@andyzhangx
Copy link
Member Author

/kind bug
/sig windows

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 26, 2018
@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2018
@nikhita
Copy link
Member

nikhita commented Sep 29, 2018

/assign @foxish
for cherry-pick approval

@foxish foxish added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 3, 2018
@foxish foxish added this to the v1.11 milestone Oct 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit cd6e3ae into kubernetes:release-1.11 Oct 4, 2018
@andyzhangx andyzhangx deleted the automated-cherry-pick-of-#68608-upstream-release-1.11 branch October 28, 2018 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@msau42 msau42 Awaiting requested review from msau42

Assignees

@foxish foxish

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andyzhangx @jsafrane @k8s-ci-robot @nikhita @foxish