Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print SizeLimit of EmptyDir #69279

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Print SizeLimit of EmptyDir #69279

merged 1 commit into from
Jan 17, 2019

Conversation

dtaniwaki
Copy link
Contributor

What this PR does / why we need it:

Print SizeLimit of EmptyDir in kubectl describe pod outputs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

N/A

Special notes for your reviewer:

Release note:

Print `SizeLimit` of `EmptyDir` in `kubectl describe pod` outputs.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 1, 2018
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 1, 2018
@dtaniwaki dtaniwaki changed the title Print sizeLimit Print SizeLimit of EmptyDir Oct 1, 2018
@mcrute
Copy link
Contributor

mcrute commented Oct 18, 2018

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2018
@mcrute
Copy link
Contributor

mcrute commented Oct 18, 2018

Should be ready to merge... adding @smarterclayton for approval.

/unassign
/assign @smarterclayton

@smarterclayton
Copy link
Contributor

If emptydir sizelimit is empty, should we be displaying “Unlimited” instead of empty string / 0?

@dtaniwaki
Copy link
Contributor Author

@smarterclayton Can I make the change you suggested or are we going to have the conclusion after some discussion?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 16, 2018
@dtaniwaki
Copy link
Contributor Author

@smarterclayton I rebased the branch and made it print Unlimited for nil and zero value. Could you review it again?

@dtaniwaki
Copy link
Contributor Author

/assign @smarterclayton

soltysh
soltysh requested changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please squash your changes into single commit.

pkg/kubectl/describe/versioned/describe.go Outdated Show resolved Hide resolved
@soltysh
Copy link
Contributor

soltysh commented Nov 21, 2018

/kind cleanup
/assign

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 21, 2018
@dtaniwaki
Copy link
Contributor Author

@soltysh I updated the code based on your feedback. Could you check it again?

@dtaniwaki
Copy link
Contributor Author

@soltysh @dshulyak @seans3 Could someone review this PR?

@mcrute
Copy link
Contributor

mcrute commented Dec 3, 2018

/lgtm

Ping @soltysh for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2018
@dtaniwaki
Copy link
Contributor Author

@soltysh Could you review this PR again?

@dtaniwaki
Copy link
Contributor Author

/test pull-kubernetes-godeps

soltysh
soltysh approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaniwaki, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9cc39a5 into kubernetes:master Jan 17, 2019
@dtaniwaki dtaniwaki deleted the print-size-limit branch March 26, 2019 06:59
@dtaniwaki dtaniwaki mentioned this pull request Sep 11, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@dshulyak dshulyak Awaiting requested review from dshulyak

@seans3 seans3 Awaiting requested review from seans3

Assignees

@mcrute mcrute

@soltysh soltysh

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dtaniwaki @mcrute @smarterclayton @soltysh @k8s-ci-robot