New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print SizeLimit of EmptyDir #69279

Merged
merged 1 commit into from Jan 17, 2019

Conversation

@dtaniwaki
Copy link
Contributor

dtaniwaki commented Oct 1, 2018

What this PR does / why we need it:

Print SizeLimit of EmptyDir in kubectl describe pod outputs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

N/A

Special notes for your reviewer:

Release note:

Print `SizeLimit` of `EmptyDir` in `kubectl describe pod` outputs.

@k8s-ci-robot k8s-ci-robot requested review from dshulyak and seans3 Oct 1, 2018

@dtaniwaki dtaniwaki changed the title Print sizeLimit Print SizeLimit of EmptyDir Oct 1, 2018

@mcrute

This comment has been minimized.

Copy link
Member

mcrute commented Oct 18, 2018

/ok-to-test
/lgtm

@mcrute

This comment has been minimized.

Copy link
Member

mcrute commented Oct 18, 2018

Should be ready to merge... adding @smarterclayton for approval.

/unassign
/assign @smarterclayton

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Oct 20, 2018

If emptydir sizelimit is empty, should we be displaying “Unlimited” instead of empty string / 0?

@dtaniwaki

This comment has been minimized.

Copy link
Contributor Author

dtaniwaki commented Oct 27, 2018

@smarterclayton Can I make the change you suggested or are we going to have the conclusion after some discussion?

@dtaniwaki

This comment has been minimized.

Copy link
Contributor Author

dtaniwaki commented Nov 16, 2018

@smarterclayton I rebased the branch and made it print Unlimited for nil and zero value. Could you review it again?

@dtaniwaki

This comment has been minimized.

Copy link
Contributor Author

dtaniwaki commented Nov 17, 2018

/assign @smarterclayton

@soltysh
Copy link
Contributor

soltysh left a comment

Also please squash your changes into single commit.

Show resolved Hide resolved pkg/kubectl/describe/versioned/describe.go Outdated
@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Nov 21, 2018

/kind cleanup
/assign

@dtaniwaki dtaniwaki force-pushed the dtaniwaki:print-size-limit branch from 9428b5e to deeb4c1 Nov 27, 2018

@dtaniwaki

This comment has been minimized.

Copy link
Contributor Author

dtaniwaki commented Nov 27, 2018

@soltysh I updated the code based on your feedback. Could you check it again?

@dtaniwaki

This comment has been minimized.

Copy link
Contributor Author

dtaniwaki commented Dec 3, 2018

@soltysh @dshulyak @seans3 Could someone review this PR?

@mcrute

This comment has been minimized.

Copy link
Member

mcrute commented Dec 3, 2018

/lgtm

Ping @soltysh for approval

@dtaniwaki

This comment has been minimized.

Copy link
Contributor Author

dtaniwaki commented Jan 5, 2019

@soltysh Could you review this PR again?

@dtaniwaki

This comment has been minimized.

Copy link
Contributor Author

dtaniwaki commented Jan 12, 2019

/test pull-kubernetes-godeps

@soltysh
Copy link
Contributor

soltysh left a comment

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaniwaki, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9cc39a5 into kubernetes:master Jan 17, 2019

19 checks passed

cla/linuxfoundation dtaniwaki authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment