-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the pod start short timeout #69291
Increase the pod start short timeout #69291
Conversation
We have seen flakes related to this timeout. Signed-off-by: Mrunal Patel <mpatel@redhat.com>
/lgtm |
/lgtm |
/approve Is this cri-o only or everything? |
/assign @smarterclayton |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, mrunalp, runcom, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Is it a regression or has it always been flaky? If it's a regression in kubelet, we should root cause and fix it. |
@yujuhong i do not think its a regression, from what we can best gather its the side-effect of running the tests in a different configuration. |
@yujuhong to elaborate, this is our attempt to fix flakes we are seeing in our openshift ci setup , ideally we would have ability to modify these hard-coded timeouts. network load, machine type, types of nodes, other concurrent testing on that node all impact timeouts. |
/kind flake |
We have seen flakes related to this timeout.
cc: @derekwaynecarr @runcom
Signed-off-by: Mrunal Patel mpatel@redhat.com
What this PR does / why we need it:
It bumps up the pod short start timeout to 2 minutes as we have seen flakes in this area in CI.