Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the pod start short timeout #69291

Merged

Conversation

mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Oct 1, 2018

We have seen flakes related to this timeout.

cc: @derekwaynecarr @runcom

Signed-off-by: Mrunal Patel mpatel@redhat.com

What this PR does / why we need it:
It bumps up the pod short start timeout to 2 minutes as we have seen flakes in this area in CI.

Bump up pod short start timeout to 2 minutes.

We have seen flakes related to this timeout.

Signed-off-by: Mrunal Patel <mpatel@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 1, 2018
@derekwaynecarr
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2018
@runcom
Copy link
Contributor

runcom commented Oct 1, 2018

/lgtm

@smarterclayton
Copy link
Contributor

/approve

Is this cri-o only or everything?

@derekwaynecarr
Copy link
Member

/assign @smarterclayton

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, mrunalp, runcom, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2018
@mrunalp
Copy link
Contributor Author

mrunalp commented Oct 1, 2018

/retest

@yujuhong
Copy link
Contributor

yujuhong commented Oct 1, 2018

Is it a regression or has it always been flaky? If it's a regression in kubelet, we should root cause and fix it.

@derekwaynecarr
Copy link
Member

@yujuhong i do not think its a regression, from what we can best gather its the side-effect of running the tests in a different configuration.

@derekwaynecarr
Copy link
Member

@yujuhong to elaborate, this is our attempt to fix flakes we are seeing in our openshift ci setup , ideally we would have ability to modify these hard-coded timeouts. network load, machine type, types of nodes, other concurrent testing on that node all impact timeouts.

@derekwaynecarr
Copy link
Member

/kind flake

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit d25e6a6 into kubernetes:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants