-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Wait for pod event to show up #69300
test: Wait for pod event to show up #69300
Conversation
adding a wait makes total sense here. /lgtm |
/assign @smarterclayton |
We are seeing flakes where pod event isn't yet visible when we check for it leading to test failure. Signed-off-by: Mrunal Patel <mpatel@redhat.com>
00c5fde
to
c771de1
Compare
/approve e2e tests should wait for events and not assume they happen immediately |
/kind flake @mrunalp can you also link to the flake issue this resolves that we hit in origin ci |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, mrunalp, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We are seeing flakes where pod event isn't yet visible when
we check for it leading to test failure.
cc: @derekwaynecarr @smarterclayton @runcom
Signed-off-by: Mrunal Patel mpatel@redhat.com
What this PR does / why we need it:
Adds a wait loop for a pod event to show up in subpath test.