Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
promote TaintBasedEvictions featuregate to beta #69824
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #69533.
Special notes for your reviewer:
referenced this pull request
Oct 15, 2018
@Huang-Wei: GitHub didn't allow me to assign the following users: for, approval.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Feel free to
@spiffxp in theory, you're right. But there are usually other aspects not being properly covered in unit test/integration test/e2e test. Like in previous release, we met some scalability issue in last moment of promoting
And even for e2e test, I don't have a gce/gke/aws env, so I only run it against my local kubeadm cluster. It'd be good to see how prow job works after the featuregate is enabled.
So based on above considerations, and our understanding/test coverage on this featuregate, at this moment we're confident to enable it in master branch.