New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote TaintBasedEvictions featuregate to beta #69824

Merged
merged 1 commit into from Oct 18, 2018

Conversation

@Huang-Wei
Member

Huang-Wei commented Oct 15, 2018

What this PR does / why we need it:

Enable TaintBasedEvictions featuregate by default.

Which issue(s) this PR fixes:

Part of #69533.

Special notes for your reviewer:

Release note:

`TaintBasedEvictions` feature is promoted to beta.

/kind feature
/sig scheduling

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Oct 15, 2018

/test pull-kubernetes-integration

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Oct 16, 2018

/assign @k82cn @bsalamat

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 16, 2018

@Huang-Wei: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @k82cn @bsalamat for approval

/unassign @smarterclayton @dchen1107

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k82cn

This comment has been minimized.

Member

k82cn commented Oct 16, 2018

/lgtm

The notes should be "Upgraded TaintBasedEvictions feature to beta" or something similar.

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 16, 2018

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Oct 16, 2018

@k82cn sure.

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Oct 16, 2018

/cc @bsalamat

for approval.

@k8s-ci-robot k8s-ci-robot requested a review from bsalamat Oct 16, 2018

@yastij

yastij approved these changes Oct 16, 2018

/lgtm

@bsalamat

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp

This comment has been minimized.

Member

spiffxp commented Oct 17, 2018

/hold
Shouldn't this be the last item to merge out of everything listed on #69533 ?

Feel free to /hold cancel if I'm wrong, but it just seems odd to move to beta and then bump test coverage. If we had test coverage gates in place we definitely wouldn't allow this?

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Oct 17, 2018

@spiffxp in theory, you're right. But there are usually other aspects not being properly covered in unit test/integration test/e2e test. Like in previous release, we met some scalability issue in last moment of promoting TaintNodeByCondition to beta.

And even for e2e test, I don't have a gce/gke/aws env, so I only run it against my local kubeadm cluster. It'd be good to see how prow job works after the featuregate is enabled.

So based on above considerations, and our understanding/test coverage on this featuregate, at this moment we're confident to enable it in master branch.

@AishSundar

This comment has been minimized.

Contributor

AishSundar commented Oct 17, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 17, 2018

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Oct 17, 2018

@spiffxp I'd like do a hold cancel after merge of #65350 is completed.

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Oct 18, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 7a53a07 into kubernetes:master Oct 18, 2018

18 checks passed

cla/linuxfoundation Huang-Wei authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@Huang-Wei Huang-Wei deleted the Huang-Wei:enable-TaintBasedEvictions branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment