Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated pod creation time based sorting code #71786

Closed
wants to merge 1 commit into from
Closed

updated pod creation time based sorting code #71786

wants to merge 1 commit into from

Conversation

pontiyaraja
Copy link
Contributor

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: The code of pod sorting, based on pod creation time is old one but its still exist, replaced it with existing code.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: Its kind of refactoring the code

Does this PR introduce a user-facing change?: No

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 6, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @pontiyaraja. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 6, 2018
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 6, 2018
@dims
Copy link
Member

dims commented Dec 6, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2018
@pontiyaraja
Copy link
Contributor Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 6, 2018
@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-local-e2e-containerized

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-local-e2e-containerized

1 similar comment
@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-local-e2e-containerized

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-local-e2e-containerized

@pontiyaraja
Copy link
Contributor Author

cc @spiffxp

@dims
Copy link
Member

dims commented Dec 7, 2018

@yujuhong @derekwaynecarr @Random-Liu Can you please lgtm on behalf of sig-node? @kubernetes/sig-node-pr-reviews

feiskyer
feiskyer reviewed Dec 8, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2018
@pontiyaraja pontiyaraja changed the title updated pod creation time based sorting code [WIP] updated pod creation time based sorting code Mar 4, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2019
@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-local-e2e-containerized

@pontiyaraja pontiyaraja mentioned this pull request Mar 5, 2019
Closed
@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-verify
/test pull-kubernetes-e2e-gce-100-performance

This was referenced Mar 6, 2019
Closed
Closed
@pontiyaraja pontiyaraja changed the title [WIP] updated pod creation time based sorting code updated pod creation time based sorting code Mar 7, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2019
@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-local-e2e-containerized
/test pull-kubernetes-e2e-gce

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 7, 2019 •
edited
Loading

@pontiyaraja: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized 66fcbe3e1c1661699d9cfc799c00a64a327d4803 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@timothysc
Copy link
Member

/assign @brahmaroutu

@brahmaroutu
Copy link
Contributor

@pontiyaraja Can we close this PR and add a unit test(as originally requested) into #75020
The unit test should test both sorted and unsorted behavior. Unsorted behavior is harder to test unless we submit a set of pods serially and observe the outcome.

@mgdevstack
Copy link
Contributor

@pontiyaraja, Any update or comment to remove blockers?

@brahmaroutu
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@brahmaroutu: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp left review comments

@feiskyer feiskyer feiskyer left review comments

@yujuhong yujuhong yujuhong left review comments

@vikaschoudhary16 vikaschoudhary16 vikaschoudhary16 left review comments

@tallclair tallclair tallclair left review comments

@pmorie pmorie Awaiting requested review from pmorie

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@feiskyer feiskyer

@brahmaroutu brahmaroutu

@vishh vishh

@tallclair tallclair

Labels
area/kubelet cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.