Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PodShareProcessNamespace feature gate out of validation #72698

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Move PodShareProcessNamespace feature gate out of validation #72698

merged 1 commit into from
Jan 9, 2019
+118 −26

Conversation

rajathagasthya
Copy link
Contributor

@rajathagasthya rajathagasthya commented Jan 8, 2019 •
edited
Loading

What type of PR is this?

/kind api-change
/kind bug

What this PR does / why we need it:
Moves feature gate checking of PodShareProcessNamespace out of validation into strategy utility methods, and avoids dropping data on update if the existing pod spec already used ShareProcessNamespace. Adds unit test for the strategy utility method and updates validation test.

Which issue(s) this PR fixes:
xref #72651

Does this PR introduce a user-facing change?:

The `spec.SecurityContext.ShareProcessNamespace` field is now dropped during creation of `Pod` objects unless the `PodShareProcessNamespace ` feature gate is enabled.

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 8, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @rajathagasthya. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jan 8, 2019
@rajathagasthya
Copy link
Contributor Author

/assign @liggitt

@liggitt liggitt mentioned this pull request Jan 9, 2019
Closed
12 tasks
liggitt
liggitt reviewed Jan 9, 2019
View reviewed changes
pkg/api/pod/util_test.go
return &api.Pod{
Spec: api.PodSpec{
SecurityContext: &api.PodSecurityContext{
ShareProcessNamespace: &[]bool{true}[0],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&[]bool{true}[0]

clever...

@liggitt
Copy link
Member

liggitt commented Jan 9, 2019

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2019
@liggitt
Copy link
Member

liggitt commented Jan 9, 2019

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 9, 2019
@liggitt liggitt added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 9, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 9, 2019
@liggitt
Copy link
Member

liggitt commented Jan 9, 2019

/retest

@liggitt
Copy link
Member

liggitt commented Jan 9, 2019

/retest

@liggitt
Copy link
Member

liggitt commented Jan 9, 2019

https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72698/pull-kubernetes-integration/40647/ failure on #71696

@rajathagasthya
Copy link
Contributor Author

/retest

@liggitt
Copy link
Member

liggitt commented Jan 9, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, rajathagasthya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 49891cc into kubernetes:master Jan 9, 2019
@rajathagasthya rajathagasthya deleted the podsharepsnamespace-72651 branch January 9, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@david-mcmahon david-mcmahon Awaiting requested review from david-mcmahon

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajathagasthya @k8s-ci-robot @liggitt