New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TokenRequestProjection feature gate out of validation #72714

Merged
merged 1 commit into from Jan 11, 2019

Conversation

@mourya007
Copy link
Contributor

mourya007 commented Jan 9, 2019

xref: #72651

/sig auth

If the `TokenRequestProjection` feature gate is disabled, projected serviceAccountToken volume sources are now dropped at object creation time, or at object update time if the existing object did not have a projected serviceAccountToken volume source. Previously, these would result in validation errors.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 9, 2019

Hi @mourya007. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/apps and removed needs-rebase labels Jan 9, 2019

@liggitt liggitt requested review from liggitt and removed request for smarterclayton and roberthbailey Jan 9, 2019

@liggitt
Copy link
Member

liggitt left a comment

good start, thanks. go ahead and squash down to a single commit as well.

Show resolved Hide resolved pkg/api/pod/util.go Outdated
Show resolved Hide resolved pkg/api/pod/util.go
Show resolved Hide resolved pkg/api/pod/util.go Outdated
Show resolved Hide resolved pkg/api/pod/util.go Outdated
Show resolved Hide resolved pkg/api/pod/util_test.go Outdated
Show resolved Hide resolved pkg/api/pod/util_test.go Outdated
Show resolved Hide resolved pkg/api/pod/util_test.go Outdated
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 9, 2019

oh, drop the issue reference from the commit title/description (Move TokenRequestProjection feature gate out of validation #72698)... including those makes github spam the issue every time the commit is pushed/pulled anywhere

Show resolved Hide resolved pkg/api/pod/util.go Outdated
@mourya007

This comment has been minimized.

Copy link
Contributor Author

mourya007 commented Jan 9, 2019

@liggitt @rajathagasthya Thanks for the review, I will update the patch as per the comments.

@mourya007 mourya007 changed the title [WIP] Move TokenRequestProjection feature gate out of validation #72698 Move TokenRequestProjection feature gate out of validation Jan 10, 2019

Show resolved Hide resolved pkg/api/pod/util.go Outdated
Show resolved Hide resolved pkg/api/pod/util.go Outdated
@rajathagasthya

This comment has been minimized.

Copy link
Contributor

rajathagasthya commented Jan 11, 2019

Looks like this requires a release note.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

@Rajat-0: you can only set the release note label to release-note-none if you are the PR author or an org member.

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 11, 2019

/kind bug
/ok-to-test
/lgtm
/approve
/priority important-soon

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mourya007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes kubernetes deleted a comment from Rajat-0 Jan 11, 2019

@kubernetes kubernetes deleted a comment from mourya007 Jan 11, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 11, 2019

added a release note as well

@k8s-ci-robot k8s-ci-robot merged commit 52d4500 into kubernetes:master Jan 11, 2019

18 checks passed

cla/linuxfoundation mourya007 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@mourya007 mourya007 deleted the mourya007:features_gate branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment