Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TokenRequestProjection feature gate out of validation #72714

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Move TokenRequestProjection feature gate out of validation #72714

merged 1 commit into from
Jan 11, 2019

Conversation

mourya007
Copy link

@mourya007 mourya007 commented Jan 9, 2019 •
edited by liggitt
Loading

xref: #72651

/sig auth

If the `TokenRequestProjection` feature gate is disabled, projected serviceAccountToken volume sources are now dropped at object creation time, or at object update time if the existing object did not have a projected serviceAccountToken volume source. Previously, these would result in validation errors.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mourya007. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2019
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 9, 2019
@liggitt liggitt requested review from liggitt and removed request for smarterclayton and roberthbailey January 9, 2019 13:56
liggitt
liggitt reviewed Jan 9, 2019
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start, thanks. go ahead and squash down to a single commit as well.

pkg/api/pod/util.go Outdated Show resolved Hide resolved
pkg/api/pod/util.go Show resolved Hide resolved
pkg/api/pod/util.go Outdated Show resolved Hide resolved
pkg/api/pod/util.go Outdated Show resolved Hide resolved
pkg/api/pod/util_test.go Outdated Show resolved Hide resolved
pkg/api/pod/util_test.go Outdated Show resolved Hide resolved
pkg/api/pod/util_test.go Outdated Show resolved Hide resolved
@liggitt liggitt mentioned this pull request Jan 9, 2019
Closed
12 tasks
@liggitt
Copy link
Member

liggitt commented Jan 9, 2019

oh, drop the issue reference from the commit title/description (Move TokenRequestProjection feature gate out of validation #72698)... including those makes github spam the issue every time the commit is pushed/pulled anywhere

rajathagasthya
rajathagasthya reviewed Jan 9, 2019
View reviewed changes
pkg/api/pod/util.go Outdated Show resolved Hide resolved
@mourya007
Copy link
Author

@liggitt @rajathagasthya Thanks for the review, I will update the patch as per the comments.

@mourya007 mourya007 changed the title [WIP] Move TokenRequestProjection feature gate out of validation #72698 Move TokenRequestProjection feature gate out of validation Jan 10, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2019
liggitt
liggitt reviewed Jan 10, 2019
View reviewed changes
pkg/api/pod/util.go Outdated Show resolved Hide resolved
liggitt
liggitt reviewed Jan 10, 2019
View reviewed changes
pkg/api/pod/util.go Outdated Show resolved Hide resolved
@rajathagasthya
Copy link
Contributor

Looks like this requires a release note.

@k8s-ci-robot
Copy link
Contributor

@Rajat-0: you can only set the release note label to release-note-none if you are the PR author or an org member.

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 11, 2019
@liggitt
Copy link
Member

liggitt commented Jan 11, 2019

/kind bug
/ok-to-test
/lgtm
/approve
/priority important-soon

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mourya007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 11, 2019
@kubernetes kubernetes deleted a comment from Rajat-0 Jan 11, 2019
@kubernetes kubernetes deleted a comment from mourya007 Jan 11, 2019
@liggitt
Copy link
Member

liggitt commented Jan 11, 2019

added a release note as well

@k8s-ci-robot k8s-ci-robot merged commit 52d4500 into kubernetes:master Jan 11, 2019
@mourya007 mourya007 deleted the features_gate branch January 17, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@rajathagasthya rajathagasthya rajathagasthya left review comments

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mourya007 @k8s-ci-robot @liggitt @rajathagasthya