add kustomize as a subcommand in kubectl #73033

Liujingfang1 · 2019-01-17T18:51:41Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add kustomize as a subcommand in kubectl
KEP
feature issue

Which issue(s) this PR fixes:

Special notes for your reviewer:

$ kubectl kustomize --help
Print a set of API resources generated from instructions in a kustomization.yaml file. 

The argument must be the path to the directory containing the file, or a git
repository URL with a path suffix specifying same with respect to the repository root. 

kubectl kustomize somedir

Examples:
  # Use the current working directory
  kubectl kustomize .
  
  # Use some shared configuration directory
  kubectl kustomize /home/configuration/production
  
  # Use a URL
  kubectl kustomize github.com/kubernetes-sigs/kustomize.git/examples/helloWorld?ref=v1.0.6

Usage:
  kubectl kustomize <dir> [flags] [options]

Use "kubectl options" for a list of global command-line options (applies to all commands).

Does this PR introduce a user-facing change?:

Kustomize is developed in its own repo https://github.com/kubernetes-sigs/kustomize

This PR added a new subcommand `kustomize` in kubectl. 
  kubectl kustomize <somedir> has the same effect as kustomize build <somedir>

To build API resources from somedir with a kustomization.yaml file
   kubectl kustomize <somedir>

This command can be piped to apply or delete 
   kubectl kustomize <somedir> | kubectl apply -f -
   kubectl kustomize <somedir> | kubectl delete -f -

k8s-ci-robot · 2019-01-17T18:51:49Z

Hi @Liujingfang1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Liujingfang1 · 2019-01-17T23:18:25Z

/sig-cli

monopole

integration looks unobtrusive

pkg/kubectl/cmd/kustomize/kustomize.go

Liujingfang1 · 2019-01-18T19:08:43Z

/ok-to-test

k8s-ci-robot · 2019-01-18T19:08:56Z

@Liujingfang1: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mengqiy · 2019-01-18T19:10:13Z

/ok-to-test

mengqiy · 2019-01-18T19:11:42Z

/priority important-soon

liggitt · 2019-02-11T21:16:27Z

pkg/kubectl/cmd/kustomize/kustomize.go

+)
+
+// NewCmdKustomize returns a kustomize command
+func NewCmdKustomize() *cobra.Command {


consume genericclioption.IOStreams as a param here (already constructed in NewKubectlCommand and passed into all other command constructors) and propagate into RunKustomizeBuild, rather than hard-coding os.Stdout

Updated to use genericclioption.IOStreams.

liggitt · 2019-02-11T21:22:06Z

from the vendor kustomize 2.0.1 commit:

squash the Godeps and vendor/sigs.k8s.io/kustomize changes to vendor kustomize
squash staging/src/k8s.io/cli-runtime/pkg/kustomize/k8sdeps changes to copy kustomize/k8sdeps into cli-runtime

liggitt · 2019-02-11T21:23:00Z

is the process for copy kustomize/k8sdeps into cli-runtime commit documented or scriptable?

liggitt · 2019-02-11T21:44:23Z

looks consistent with the proposed integration. a few cleanup comments, then lgtm

Liujingfang1 · 2019-02-11T22:31:37Z

@liggitt

from the vendor kustomize 2.0.1 commit:

squash the Godeps and vendor/sigs.k8s.io/kustomize changes to vendor kustomize

squash staging/src/k8s.io/cli-runtime/pkg/kustomize/k8sdeps changes to copy kustomize/k8sdeps into cli-runtime

This is done.

is the process for copy kustomize/k8sdeps into cli-runtime commit documented or scriptable?

This is documented https://github.com/kubernetes-sigs/kustomize/blob/master/build/vendor_kustomize.sh#L74
There is a function to copy that directory and update the import paths.

liggitt · 2019-02-11T22:53:56Z

/lgtm
/approve
/retest

/hold
for @soltysh

k8s-ci-robot · 2019-02-11T22:54:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, Liujingfang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~Godeps/OWNERS~~ [liggitt]
~~build/visible_to/OWNERS~~ [liggitt]
~~pkg/kubectl/OWNERS~~ [liggitt]
~~staging/OWNERS~~ [liggitt]
~~vendor/OWNERS~~ [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2019-02-12T01:30:05Z

@Liujingfang1: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-kops-aws	0126f745390e563305da14cd6c337033470a2cbf	link	`/test pull-kubernetes-e2e-kops-aws`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Liujingfang1 · 2019-02-12T02:38:50Z

/test pull-kubernetes-verify

soltysh

/hold cancel
/lgtm

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 17, 2019

k8s-ci-robot requested review from dchen1107 and dixudx January 17, 2019 18:52

k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 17, 2019

Liujingfang1 force-pushed the kustomizeSubcommand branch 2 times, most recently from 0a4433a to bcba36f Compare January 17, 2019 22:26

monopole reviewed Jan 17, 2019

View reviewed changes

pkg/kubectl/cmd/kustomize/kustomize.go Outdated Show resolved Hide resolved

pkg/kubectl/cmd/kustomize/kustomize.go Outdated Show resolved Hide resolved

Liujingfang1 force-pushed the kustomizeSubcommand branch 2 times, most recently from d7ea877 to 71c10ca Compare January 18, 2019 19:05

Liujingfang1 changed the title ~~[WIP] add kustomize as a subcommand in kubectl~~ add kustomize as a subcommand in kubectl Jan 18, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2019

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2019

k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 18, 2019

monopole mentioned this pull request Feb 11, 2019

integrate Kustomize into kubectl kubernetes/enhancements#633

Closed

liggitt reviewed Feb 11, 2019

View reviewed changes

vendor kustomize

23a9b0c

Liujingfang1 force-pushed the kustomizeSubcommand branch from cbcd616 to 8bda532 Compare February 11, 2019 22:27

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 11, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2019

Liujingfang1 added 3 commits February 11, 2019 16:42

copy kustomize/k8sdeps into cli-runtime

74a64a9

add function to run kustomize build

0433a30

add kustomize as a subcommand in kubectl

8d6ab20

Liujingfang1 force-pushed the kustomizeSubcommand branch from 8bda532 to 8d6ab20 Compare February 12, 2019 00:44

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2019

soltysh approved these changes Feb 12, 2019

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2019

k8s-ci-robot merged commit 66149bd into kubernetes:master Feb 12, 2019

Liujingfang1 mentioned this pull request Feb 15, 2019

update the status of kustomize subcommand integration kep kubernetes/enhancements#838

Merged

mattfarina mentioned this pull request Feb 27, 2019

Either test on Windows or remove the windows OS release kubernetes-sigs/kustomize#791

Closed

zeeZ mentioned this pull request Mar 19, 2019

Kustomize integration support fluxcd/flux#1261

Closed

This was referenced Mar 28, 2019

Use kubectl kustomize instead of kustomize kubernetes-sigs/cluster-api#859

Closed

Use kubectl kustomize instead of kustomize kubernetes-sigs/cluster-api-provider-openstack#282

Closed

Liujingfang1 mentioned this pull request Jun 20, 2019

REQUEST: New membership for Liujingfang1 kubernetes/org#940

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add kustomize as a subcommand in kubectl #73033

add kustomize as a subcommand in kubectl #73033

Liujingfang1 commented Jan 17, 2019 •

edited

Loading

k8s-ci-robot commented Jan 17, 2019

Liujingfang1 commented Jan 17, 2019

monopole left a comment

Liujingfang1 commented Jan 18, 2019

k8s-ci-robot commented Jan 18, 2019

mengqiy commented Jan 18, 2019

mengqiy commented Jan 18, 2019

liggitt Feb 11, 2019 •

edited

Loading

Liujingfang1 Feb 11, 2019

liggitt commented Feb 11, 2019

liggitt commented Feb 11, 2019

liggitt commented Feb 11, 2019

Liujingfang1 commented Feb 11, 2019

liggitt commented Feb 11, 2019

k8s-ci-robot commented Feb 11, 2019

k8s-ci-robot commented Feb 12, 2019 •

edited

Loading

Liujingfang1 commented Feb 12, 2019

soltysh left a comment

add kustomize as a subcommand in kubectl #73033

add kustomize as a subcommand in kubectl #73033

Conversation

Liujingfang1 commented Jan 17, 2019 • edited Loading

k8s-ci-robot commented Jan 17, 2019

Liujingfang1 commented Jan 17, 2019

monopole left a comment

Choose a reason for hiding this comment

Liujingfang1 commented Jan 18, 2019

k8s-ci-robot commented Jan 18, 2019

mengqiy commented Jan 18, 2019

mengqiy commented Jan 18, 2019

liggitt Feb 11, 2019 • edited Loading

Choose a reason for hiding this comment

Liujingfang1 Feb 11, 2019

Choose a reason for hiding this comment

liggitt commented Feb 11, 2019

liggitt commented Feb 11, 2019

liggitt commented Feb 11, 2019

Liujingfang1 commented Feb 11, 2019

liggitt commented Feb 11, 2019

k8s-ci-robot commented Feb 11, 2019

k8s-ci-robot commented Feb 12, 2019 • edited Loading

Liujingfang1 commented Feb 12, 2019

soltysh left a comment

Choose a reason for hiding this comment

Liujingfang1 commented Jan 17, 2019 •

edited

Loading

liggitt Feb 11, 2019 •

edited

Loading

k8s-ci-robot commented Feb 12, 2019 •

edited

Loading