-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the http2 GOAWAY error to IsProbableEOF for ignoring in watch #73277
Conversation
http2 is allowed to tell us to go away, and for watch it is safe to exit and restart in almost all cases where a connection is forcibly closed by the upstream. This error message happens a lot behind ELB and other http2 aware proxies. Treat the error as "basically done" as suggested by golang/go#18639 (comment)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm this also would affect this code path: kubernetes/staging/src/k8s.io/client-go/rest/request.go Lines 582 to 589 in 2cd8825
given the other network errors that were triggering the code path, that seems reasonable is there any way to test this to catch message drift? |
/assign @roycaihw |
/cc @wenjiaswe |
http2 is allowed to tell us to go away, and for watch it is safe to exit and restart in almost all cases where a connection is forcibly closed by the upstream. This error message happens a lot behind ELB and other http2 aware proxies.
Treat the error as "basically done" as suggested by: golang/go#18639 (comment)
Otherwise, we log at V(0) which shows up in command line tools, scripting, etc and is totally not actionable.
For instance, in a CLI tool using watch.Until against an apiserver behind AWS ELB:
/kind bug