New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the http2 GOAWAY error to IsProbableEOF for ignoring in watch #73277

Merged
merged 1 commit into from Jan 24, 2019

Conversation

@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 24, 2019

http2 is allowed to tell us to go away, and for watch it is safe to exit and restart in almost all cases where a connection is forcibly closed by the upstream. This error message happens a lot behind ELB and other http2 aware proxies.

Treat the error as "basically done" as suggested by: golang/go#18639 (comment)

Otherwise, we log at V(0) which shows up in command line tools, scripting, etc and is totally not actionable.

For instance, in a CLI tool using watch.Until against an apiserver behind AWS ELB:

level=info msg="Waiting up to 30m0s for the bootstrap-complete event..."
E0124 06:00:48.845920      29 streamwatcher.go:109] Unable to decode an event from the watch stream: http2: server sent GOAWAY and closed the connection; LastStreamID=3, ErrCode=NO_ERROR, debug=""

/kind bug

When a watch is closed by an HTTP2 load balancer and we are told to go away, skip printing the message to stderr by default.
Add the http2 GOAWAY error to IsProbableEOF for ignoring in watch
http2 is allowed to tell us to go away, and for watch it is safe
to exit and restart in almost all cases where a connection is
forcibly closed by the upstream. This error message happens a lot
behind ELB and other http2 aware proxies.

Treat the error as "basically done" as suggested by

golang/go#18639 (comment)
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 24, 2019

/lgtm

this also would affect this code path:

if err != nil {
// The watch stream mechanism handles many common partial data errors, so closed
// connections can be retried in many cases.
if net.IsProbableEOF(err) {
return watch.NewEmptyWatch(), nil
}
return nil, err
}

given the other network errors that were triggering the code path, that seems reasonable

is there any way to test this to catch message drift?

@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Jan 24, 2019

/assign @roycaihw

@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Jan 24, 2019

@k8s-ci-robot k8s-ci-robot requested a review from wenjiaswe Jan 24, 2019

@k8s-ci-robot k8s-ci-robot merged commit 4a44df3 into kubernetes:master Jan 24, 2019

18 checks passed

cla/linuxfoundation smarterclayton authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment