Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add the http2 GOAWAY error to IsProbableEOF for ignoring in watch #73277
http2 is allowed to tell us to go away, and for watch it is safe to exit and restart in almost all cases where a connection is forcibly closed by the upstream. This error message happens a lot behind ELB and other http2 aware proxies.
Treat the error as "basically done" as suggested by: golang/go#18639 (comment)
Otherwise, we log at V(0) which shows up in command line tools, scripting, etc and is totally not actionable.
For instance, in a CLI tool using watch.Until against an apiserver behind AWS ELB:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: smarterclayton
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing