Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress extensions/v1beta1 -> networking.k8s.io/v1beta1 #74057

Merged
merged 5 commits into from Feb 21, 2019

Conversation

@liggitt
Copy link
Member

liggitt commented Feb 14, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • first commit moves internal Ingress types, validation, and REST storage to the networking package
    • types and validation were copied with no changes (other than package fixup)
    • no externally visible API changes
  • second commit copies the extensions/v1beta1 Ingress types to networking.k8s.io/v1beta1

Which issue(s) this PR fixes:
xref kubernetes/enhancements#758
xref #43214

Does this PR introduce a user-facing change?:

The Ingress API is now available via `networking.k8s.io/v1beta1`. `extensions/v1beta1` Ingress objects are deprecated and will no longer be served in v1.18.

/sig network
/cc @bowei @thockin

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Feb 14, 2019

/lgtm

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 14, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 14, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt liggitt force-pushed the liggitt:ingress-network-v1beta1 branch from 90291cf to ba319ac Feb 14, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 14, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 14, 2019

fixed up lint and godep.json issues

@liggitt liggitt force-pushed the liggitt:ingress-network-v1beta1 branch 2 times, most recently from 68cb037 to fad8256 Feb 14, 2019

@liggitt liggitt added this to the v1.14 milestone Feb 15, 2019

@thockin thockin self-assigned this Feb 15, 2019

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Feb 15, 2019

Will try to get to this tomorrow.

@liggitt liggitt added this to Assigned in API Reviews Feb 20, 2019

@liggitt liggitt force-pushed the liggitt:ingress-network-v1beta1 branch from fad8256 to dcef188 Feb 20, 2019

// by an IngressRule, the SNI host is used for termination and value of the
// Host header is used for routing.
// +optional
SecretName string

This comment has been minimized.

@thockin

thockin Feb 21, 2019

Member

Because this is a cross-group, no-delta move, I won't harp, but we should probably make this a pointer before GA

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Feb 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 21, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 21, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

liggitt added some commits Feb 14, 2019

@liggitt liggitt force-pushed the liggitt:ingress-network-v1beta1 branch from dcef188 to f7f153e Feb 21, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 21, 2019

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 21, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 21, 2019

regenerated openapi doc to pick up deprecation warning from #73783, retagging

@liggitt liggitt added the lgtm label Feb 21, 2019

@k8s-ci-robot k8s-ci-robot merged commit 7d75b73 into kubernetes:master Feb 21, 2019

16 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:ingress-network-v1beta1 branch Feb 22, 2019

rfranzke added a commit to gardener/gardener that referenced this pull request Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.