Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingress extensions/v1beta1 -> networking.k8s.io/v1beta1 #74057

Merged
merged 5 commits into from
Feb 21, 2019
Merged

Ingress extensions/v1beta1 -> networking.k8s.io/v1beta1 #74057

merged 5 commits into from
Feb 21, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 14, 2019 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • first commit moves internal Ingress types, validation, and REST storage to the networking package
    • types and validation were copied with no changes (other than package fixup)
    • no externally visible API changes
  • second commit copies the extensions/v1beta1 Ingress types to networking.k8s.io/v1beta1

Which issue(s) this PR fixes:
xref kubernetes/enhancements#758
xref #43214

Does this PR introduce a user-facing change?:

The Ingress API is now available via `networking.k8s.io/v1beta1`. `extensions/v1beta1` Ingress objects are deprecated and will no longer be served in v1.18.

/sig network
/cc @bowei @thockin

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/kubectl kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 14, 2019
@liggitt liggitt mentioned this pull request Feb 14, 2019
Closed
1 task
@bowei
Copy link
Member

bowei commented Feb 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2019
@liggitt
Copy link
Member Author

liggitt commented Feb 14, 2019

fixed up lint and godep.json issues

@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 14, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 14, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2019
@liggitt
Copy link
Member Author

liggitt commented Feb 21, 2019 •
edited

regenerated openapi doc to pick up deprecation warning from #73783, retagging

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7d75b73 into kubernetes:master Feb 21, 2019
@liggitt liggitt deleted the ingress-network-v1beta1 branch February 22, 2019 15:55
@spiffxp spiffxp mentioned this pull request Feb 23, 2019
Closed
@liggitt liggitt mentioned this pull request Feb 28, 2019
Merged
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 20, 2019
@rfranzke
Ingress API is served via networking.k8s.io/v1beta1 API
525f0df 
See kubernetes/kubernetes#74057
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 26, 2019
@rfranzke
Ingress API is served via networking.k8s.io/v1beta1 API
a24e677 
See kubernetes/kubernetes#74057
@liggitt liggitt removed this from Assigned in API Reviews Mar 29, 2019
@qw1mb0 qw1mb0 mentioned this pull request Jun 26, 2019
Closed
@dustin-decker dustin-decker mentioned this pull request Jul 9, 2019
Closed
@mikkeloscar mikkeloscar mentioned this pull request Jul 15, 2019
Merged
15 tasks
@tengqm tengqm mentioned this pull request Jul 24, 2019
Closed
@clarketm clarketm mentioned this pull request Jul 24, 2019
Closed
@entropitor entropitor mentioned this pull request Jul 31, 2019
Closed
This was referenced Aug 2, 2019
Closed
Closed
@life1347 life1347 mentioned this pull request Sep 27, 2019
Closed
@SkeLLLa SkeLLLa mentioned this pull request Feb 12, 2020
Closed
@huytmb huytmb mentioned this pull request Feb 16, 2020
Closed
@jessesuen jessesuen mentioned this pull request Mar 5, 2020
Merged
lens0021 added a commit to femiwiki/kubernetes that referenced this pull request May 9, 2020
@lens0021
Configure certificate
d43b667 
Ingress extensions/v1beta1 -> networking.k8s.io/v1beta1: kubernetes/kubernetes#74057
@SoftCreatR SoftCreatR mentioned this pull request Oct 1, 2020
Closed
@Sea-n Sea-n mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@bowei bowei Awaiting requested review from bowei

Assignees

@bowei bowei

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @bowei @fejta-bot @thockin @k8s-ci-robot