Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #74755: Revert kubelet to default to ttl cache secret/configmap #74842

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Automated cherry pick of #74755: Revert kubelet to default to ttl cache secret/configmap #74842

merged 1 commit into from
Mar 5, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 2, 2019

Cherry pick of #74755 on release-1.12.

#74755: Revert kubelet to default to ttl cache secret/configmap

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/kubelet needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 2, 2019
@liggitt liggitt added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 2, 2019
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 2, 2019
@liggitt liggitt added this to the v1.12 milestone Mar 2, 2019
@liggitt
Copy link
Member Author

liggitt commented Mar 2, 2019

/cc @feiskyer @yujuhong

neolit123
neolit123 approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2019
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 4, 2019
@yujuhong
Copy link
Contributor

yujuhong commented Mar 4, 2019

/lgtm
/approve

@fabriziopandini
Copy link
Member

/approve
/lgtm
Kubeadm just tests kubelet component config, so this should reflect what sig-node choose as default

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, liggitt, neolit123, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
@neolit123
Copy link
Member

/retest

@RobertKrawitz RobertKrawitz mentioned this pull request Mar 4, 2019
Closed
@neolit123
Copy link
Member

neolit123 commented Mar 4, 2019 •
edited
Loading

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/74842/pull-kubernetes-verify/124755/build-log.txt

I0304 23:05:27.794] �[0;31mhack/make-rules/../../hack/verify-godeps.sh�[0m
I0304 23:05:27.795] Makefile:128: recipe for target 'verify' failed
W0304 23:05:27.896] make: *** [verify] Error 1

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt
Copy link
Member Author

liggitt commented Mar 5, 2019

/retest

1 similar comment
@neolit123
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit a85aa81 into kubernetes:release-1.12 Mar 5, 2019
@RobertKrawitz RobertKrawitz mentioned this pull request Mar 5, 2019
Merged
@liggitt liggitt mentioned this pull request Mar 7, 2019
Closed
@liggitt liggitt deleted the automated-cherry-pick-of-#74755-upstream-release-1.12 branch April 22, 2019 15:09
@my1990
Copy link

my1990 commented Aug 24, 2020

The solution to this problem is to upgrade to kubelet 1.14+? What can be done by modifying the configuration instead of upgrading kubelet? thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@detiber detiber Awaiting requested review from detiber

@feiskyer feiskyer Awaiting requested review from feiskyer

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@neolit123 neolit123

@fabriziopandini fabriziopandini

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@liggitt @yujuhong @fabriziopandini @k8s-ci-robot @neolit123 @fejta-bot @my1990 @feiskyer