Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 74755: Revert kubelet to default to ttl cache secret/configmap #22236

Conversation

RobertKrawitz
Copy link
Contributor

Reference kubernetes/kubernetes#74842 (Kubernetes 1.12 backport)

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 5, 2019
@RobertKrawitz
Copy link
Contributor Author

@rphillips
Copy link
Contributor

/lgtm

@RobertKrawitz
Copy link
Contributor Author

/retest

3 similar comments
@RobertKrawitz
Copy link
Contributor Author

/retest

@RobertKrawitz
Copy link
Contributor Author

/retest

@rphillips
Copy link
Contributor

/retest

@RobertKrawitz
Copy link
Contributor Author

/cc @derekwaynecarr

@sjenning
Copy link
Contributor

sjenning commented Mar 7, 2019

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RobertKrawitz, rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2019
@openshift-merge-robot openshift-merge-robot merged commit 995d7df into openshift:master Mar 7, 2019
@RobertKrawitz RobertKrawitz deleted the upstream-74755-revert-cache-manager branch March 7, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants