-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
potential backport on okd 4.0 assuming K8s 1.12 is being targeted #520
Comments
Thanks for the heads-up! I'm going to let @runcom close this to make sure he sees it. |
is there anything we (mco) should do here? (I'm probably missing something obvious) Is this an heads up that we're just going to upgrade golang and make sure everything still works fine here? |
For now we're going to simply cherrypick the point fix, revert the use of the watch-based monitoring strategy in favor of the previous caching code that doesn't have this problem (I have a cherrypick PR waiting to go as soon as kubernetes/kubernetes#74842 merges). @rphillips and I were discussing whether the MCO should block any attempt by the user to change the default; that's what issue is about. |
I added a PR to prevent the KubeletConfiguration variable being changed by the user. |
Awesome, thanks for the clarification |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Since this has been addressed, closing. |
you might already be aware of the issue, however in case you haven't i thought i should just give you a heads up.
Assuming you targeting 4.0 with 1.12 (as per latest openshift blog published by @crawford ) you should be aware of this issue which is forcing a golang version bump before 1.14 gets into freeze move
There is also a workaround which i think you can take it in your kubelet config - kubernetes/kubernetes#74755
/cc @wking @smarterclayton
please close this issue once you ack, i couldn't find a better way to notify the right group
The text was updated successfully, but these errors were encountered: