Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.11] Automated cherry pick of #75144: kubelet: updated logic of verifying a static critical pod #74996

Conversation

@Huang-Wei
Copy link
Member

commented Mar 5, 2019

Cherry pick of #75144 on release-1.11.

#75144: kubelet: updated logic of verifying a static critical pod

@Huang-Wei Huang-Wei changed the title Automated cherry pick of #74222: kubelet: return mirror pod in GetActivePods() [1.11] Automated cherry pick of #74222: kubelet: return mirror pod in GetActivePods() Mar 5, 2019

@Huang-Wei

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

/kind bug
/priority important-soon
/sig node

@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and ncdc Mar 5, 2019

@Huang-Wei Huang-Wei force-pushed the Huang-Wei:automated-cherry-pick-of-#74222-upstream-release-1.11 branch 3 times, most recently from ff6c559 to 9df175b Mar 5, 2019

@Huang-Wei

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

/assign @derekwaynecarr
for approval

/assign @feiskyer
for 1.11 patch release

@Huang-Wei

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

/hold

@Huang-Wei Huang-Wei force-pushed the Huang-Wei:automated-cherry-pick-of-#74222-upstream-release-1.11 branch from 9df175b to 4edc2ad Mar 15, 2019

@Huang-Wei Huang-Wei changed the title [1.11] Automated cherry pick of #74222: kubelet: return mirror pod in GetActivePods() [1.11] Automated cherry pick of #75144: kubelet: updated logic of verifying a static critical pod Mar 15, 2019

@Huang-Wei

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

/retest

@Huang-Wei Huang-Wei force-pushed the Huang-Wei:automated-cherry-pick-of-#74222-upstream-release-1.11 branch 2 times, most recently from f292610 to dd30816 Mar 15, 2019

kubelet: updated logic of verifying a static critical pod
- check if a pod is static by its static pod info
- meanwhile, check if a pod is critical by its corresponding mirror pod info

@Huang-Wei Huang-Wei force-pushed the Huang-Wei:automated-cherry-pick-of-#74222-upstream-release-1.11 branch from dd30816 to 416a76f Mar 15, 2019

@Huang-Wei

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

/retest

@Huang-Wei

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2019

/hold cancel

Good to be merged now.

@Huang-Wei

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

@derekwaynecarr could you help to /approve? @feiskyer wants to include this in upcoming 1.11 release. Thanks!

@derekwaynecarr

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 21, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@foxish foxish added this to the v1.11 milestone Apr 1, 2019

@k8s-ci-robot k8s-ci-robot merged commit dd668fc into kubernetes:release-1.11 Apr 1, 2019

17 checks passed

cla/linuxfoundation Huang-Wei authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@Huang-Wei Huang-Wei deleted the Huang-Wei:automated-cherry-pick-of-#74222-upstream-release-1.11 branch Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.