Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix message of failed sync #75260

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Fix message of failed sync #75260

merged 1 commit into from
Jul 17, 2019

Conversation

jsafrane
Copy link
Member

Message couldn't propagate object cache ends up in Event about failed mount and it looks confusing to users. Trying failed to sync X cache (where X is either secret or configmap).

From:

MountVolume.SetUp failed for volume "secret-prometheus-k8s-proxy" : couldn't propagate object cache: timed out waiting for the condition

To:
MountVolume.SetUp failed for volume "secret-prometheus-k8s-proxy" : failed to sync secret cache: timed out waiting for the condition

/kind cleanup
/sig node

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Mar 11, 2019
feiskyer
feiskyer reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2019
@poothia
Copy link
Contributor

poothia commented Mar 26, 2019

lgtm

@jsafrane
Copy link
Member Author

/assign @tallclair @derekwaynecarr
for approval

@xichengliudui
Copy link
Contributor

xichengliudui commented Apr 10, 2019 •
edited
Loading

@jsafrane
I may have the same problem as you: couldn't propagate object cache: timed out waiting for the condition.
there is an exception log in kubelet. ref: https://github.com/xichengliudui/public-repo/blob/master/logs.md

@xichengliudui
Copy link
Contributor

Are they the same?

tallclair
tallclair reviewed Apr 10, 2019
View reviewed changes
pkg/kubelet/util/manager/watch_based_manager.go Outdated
@@ -166,7 +166,7 @@ func (c *objectCache) Get(namespace, name string) (runtime.Object, error) {
return nil, fmt.Errorf("object %q/%q not registered", namespace, name)
}
if err := wait.PollImmediate(10*time.Millisecond, time.Second, item.hasSynced); err != nil {
return nil, fmt.Errorf("couldn't propagate object cache: %v", err)
return nil, fmt.Errorf("failed to sync %s cache: %v", c.groupResource.Resource, err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return nil, fmt.Errorf("failed to sync %s cache: %v", c.groupResource.Resource, err)
return nil, fmt.Errorf("failed to sync %s cache: %v", c.groupResource.String(), err)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@xichengliudui xichengliudui mentioned this pull request Apr 12, 2019
Closed
@jsafrane
Fix message of failed sync
96c41f8 
From:
MountVolume.SetUp failed for volume "secret-prometheus-k8s-proxy" :
couldn't propagate object cache: timed out waiting for the condition

To:
MountVolume.SetUp failed for volume "secret-prometheus-k8s-proxy" : failed
to sync secret cache: timed out waiting for the condition
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2019
@poothia
Copy link
Contributor

poothia commented Jul 11, 2019

i think this issue can be closed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@jsafrane
Copy link
Member Author

I forgot about this one .I still think this PR is useful, @tallclair, would you please check again?

@tallclair
Copy link
Member

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 74f371c into kubernetes:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@tallclair tallclair tallclair left review comments

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@feiskyer feiskyer

@derekwaynecarr derekwaynecarr

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jsafrane @poothia @xichengliudui @fejta-bot @tallclair @k8s-ci-robot @feiskyer @derekwaynecarr