Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to go1.12.1 #75390

Closed
wants to merge 1 commit into
base: master
from

Conversation

@liggitt
Copy link
Member

liggitt commented Mar 15, 2019

/kind feature

Does this PR introduce a user-facing change?:

Update to use golang 1.12.1

pending availability of golang:1.12.1 image and build-cross image

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 15, 2019

@k8s-ci-robot k8s-ci-robot requested review from ixdy , javier-b-perez and zmerlynn Mar 15, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Mar 15, 2019

/retest
why did bazel fail?

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 15, 2019

Bad sha, apparently

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 15, 2019

Will recheck and repush

Show resolved Hide resolved build/root/WORKSPACE Outdated

@liggitt liggitt force-pushed the liggitt:go1.12.1 branch from 4e25bdc to 25be2a8 Mar 15, 2019

@liggitt liggitt added this to the v1.14 milestone Mar 15, 2019

@nikopen

This comment has been minimized.

Copy link
Member

nikopen commented Mar 15, 2019

/retest

1 similar comment
@nikopen

This comment has been minimized.

Copy link
Member

nikopen commented Mar 15, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 15, 2019

@liggitt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross 25be2a8 link /test pull-kubernetes-cross
pull-kubernetes-godeps 25be2a8 link /test pull-kubernetes-godeps
pull-kubernetes-verify 25be2a8 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 15, 2019

the three failing jobs are pending golang:1.12.1 docker image availability (docker-library/official-images#5550) and the build-cross image

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 15, 2019

Closing in favor of #75413

@liggitt liggitt closed this Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.