Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to go1.12.1 #75390

Closed
wants to merge 1 commit into from
Closed

update to go1.12.1 #75390

wants to merge 1 commit into from

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 15, 2019 •
edited
Loading

/kind feature

Does this PR introduce a user-facing change?:

Update to use golang 1.12.1

pending availability of golang:1.12.1 image and build-cross image

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 15, 2019
@liggitt liggitt mentioned this pull request Mar 15, 2019
Closed
@liggitt
Copy link
Member Author

liggitt commented Mar 15, 2019

/cc @javier-b-perez @ixdy

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 15, 2019
@ixdy
Copy link
Member

ixdy commented Mar 15, 2019

/retest
why did bazel fail?

@liggitt
Copy link
Member Author

liggitt commented Mar 15, 2019

Bad sha, apparently

@liggitt
Copy link
Member Author

liggitt commented Mar 15, 2019

Will recheck and repush

dims
dims reviewed Mar 15, 2019
View reviewed changes
build/root/WORKSPACE Outdated Show resolved Hide resolved
@liggitt liggitt added this to the v1.14 milestone Mar 15, 2019
@nikopen
Copy link
Contributor

nikopen commented Mar 15, 2019

/retest

1 similar comment
@nikopen
Copy link
Contributor

nikopen commented Mar 15, 2019

/retest

@k8s-ci-robot
Copy link
Contributor

@liggitt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross 25be2a8 link /test pull-kubernetes-cross
pull-kubernetes-godeps 25be2a8 link /test pull-kubernetes-godeps
pull-kubernetes-verify 25be2a8 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Member Author

liggitt commented Mar 15, 2019 •
edited
Loading

the three failing jobs are pending golang:1.12.1 docker image availability (docker-library/official-images#5550) and the build-cross image

@liggitt
Copy link
Member Author

liggitt commented Mar 15, 2019

Closing in favor of #75413

@liggitt liggitt closed this Mar 15, 2019
@liggitt liggitt deleted the go1.12.1 branch November 25, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@ixdy ixdy Awaiting requested review from ixdy

@javier-b-perez javier-b-perez Awaiting requested review from javier-b-perez

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.
5 participants
@liggitt @k8s-ci-robot @ixdy @nikopen @dims