Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go 1.12.4 #76576

Merged
merged 1 commit into from Apr 20, 2019

Conversation

@cblecker
Copy link
Member

cblecker commented Apr 15, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update to use golang 1.12.4

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to use go 1.12.4
@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 15, 2019

/priority important-soon
/sig release

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ixdy and zmerlynn Apr 15, 2019

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 15, 2019

/test pull-kubernetes-node-e2e

@javier-b-perez

This comment has been minimized.

Copy link
Contributor

javier-b-perez commented Apr 17, 2019

I have created the image staging-k8s.gcr.io/kube-cross:v1.12.4-1
Waiting for image to propagate to k8s.gcr.io/kube-cross:v1.12.4-1, might take a few hours. I will report back

@javier-b-perez

This comment has been minimized.

Copy link
Contributor

javier-b-perez commented Apr 17, 2019

Image should be there now
/test pull-kubernetes-cross

@javier-b-perez

This comment has been minimized.

Copy link
Contributor

javier-b-perez commented Apr 17, 2019

/test pull-kubernetes-verify

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 18, 2019

/check-cla

2 similar comments
@cjwagner

This comment has been minimized.

Copy link
Member

cjwagner commented Apr 18, 2019

/check-cla

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 20, 2019

/check-cla

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 20, 2019

Looks like tests are passing. Can I get an LGTM?

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 20, 2019

/assign @javier-b-perez

@dims

This comment has been minimized.

Copy link
Member

dims commented Apr 20, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 20, 2019

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 20, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit b384712 into kubernetes:master Apr 20, 2019

20 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:go-1.12.4 branch Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.