Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go 1.12.4 #76576

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Update to go 1.12.4 #76576

merged 1 commit into from
Apr 20, 2019

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Apr 15, 2019 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update to use golang 1.12.4

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to use go 1.12.4

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 15, 2019
@cblecker
Copy link
Member Author

/priority important-soon
/sig release

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2019
@cblecker
Copy link
Member Author

cblecker commented Apr 15, 2019 •
edited
Loading

/test pull-kubernetes-node-e2e

@javier-b-perez
Copy link
Contributor

I have created the image staging-k8s.gcr.io/kube-cross:v1.12.4-1
Waiting for image to propagate to k8s.gcr.io/kube-cross:v1.12.4-1, might take a few hours. I will report back

@javier-b-perez
Copy link
Contributor

Image should be there now
/test pull-kubernetes-cross

@javier-b-perez
Copy link
Contributor

/test pull-kubernetes-verify

@cblecker
Copy link
Member Author

/check-cla

2 similar comments
@cjwagner
Copy link
Member

/check-cla

@cblecker
Copy link
Member Author

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2019
@cblecker
Copy link
Member Author

cblecker commented Apr 20, 2019 •
edited
Loading

Looks like tests are passing. Can I get an LGTM?

@cblecker
Copy link
Member Author

/assign @javier-b-perez

@dims
Copy link
Member

dims commented Apr 20, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2019
@cblecker
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit b384712 into kubernetes:master Apr 20, 2019
@cblecker cblecker deleted the go-1.12.4 branch April 20, 2019 05:10
This was referenced Apr 26, 2019
Closed
Closed
@cblecker cblecker mentioned this pull request May 13, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request May 14, 2019
@k8s-ci-robot
Merge pull request #77831 from cblecker/automated-cherry-pick-of-#76576-
66049e3 
#77528-upstream-release-1.14

Automated cherry pick of #76576: Update to go 1.12.4 #77528: Update to go 1.12.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy Awaiting requested review from ixdy

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@dims dims

@javier-b-perez javier-b-perez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cblecker @k8s-ci-robot @javier-b-perez @cjwagner @dims