Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go 1.12.5 #77528

Merged
merged 1 commit into from May 9, 2019

Conversation

@cblecker
Copy link
Member

commented May 7, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Updates to go 1.12.5. This fixes a significant API call latency regression

Which issue(s) this PR fixes:
Fixes #75833

Does this PR introduce a user-facing change?:

Update to use go 1.12.5
@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

/hold
/sig release
/priority critical-urgent

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

Next steps:

  • Waiting for the docker hub image to publish. The PR is merged, so this should happen shortly.
  • Need a new version of the bazel rules_go to be published. (cc: @jayconrod)
@javier-b-perez

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

I still don't see the new golang image

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

@javier-b-perez Looks like the images are now published:

Digest: sha256:e52f9c9ea80fa182a78bd83a9f9e107d173b8e7fd922dbb0c60c8020a88fb7f6
Status: Downloaded newer image for golang:1.12.5
@javier-b-perez

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

/test pull-kubernetes-cross

@javier-b-perez

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

/LGTM
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label May 8, 2019

@wojtek-t

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@cblecker - can you please update the sha in the PR?

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

@wojtek-t New rules_go hasn't been released yet: https://github.com/bazelbuild/rules_go/releases

@jayconrod: is there an ETA on the next cut?

@cblecker cblecker force-pushed the cblecker:go-1.12.5 branch from 312bbc2 to 31ffa88 May 8, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 8, 2019

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

/hold cancel

All test are passing. This should be ready to ship. Looking for final review and LGTM.

@dims

This comment has been minimized.

Copy link
Member

commented May 9, 2019

/lgtm

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 851afa0 into kubernetes:master May 9, 2019

20 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:go-1.12.5 branch May 9, 2019

@wojtek-t

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Thanks a lot for this!

k8s-ci-robot added a commit that referenced this pull request May 14, 2019

Merge pull request #77831 from cblecker/automated-cherry-pick-of-#76576-
#77528-upstream-release-1.14

Automated cherry pick of #76576: Update to go 1.12.4 #77528: Update to go 1.12.5

justinsb added a commit to justinsb/kops that referenced this pull request May 19, 2019

justinsb added a commit to justinsb/kops that referenced this pull request May 19, 2019

justinsb added a commit to justinsb/kops that referenced this pull request May 19, 2019

justinsb added a commit to justinsb/kops that referenced this pull request May 19, 2019

justinsb added a commit to justinsb/kops that referenced this pull request May 19, 2019

justinsb added a commit to justinsb/kops that referenced this pull request May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.