Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go 1.12.5 #77528

Merged
merged 1 commit into from May 9, 2019
Merged

Update to go 1.12.5 #77528

merged 1 commit into from May 9, 2019

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented May 7, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Updates to go 1.12.5. This fixes a significant API call latency regression

Which issue(s) this PR fixes:
Fixes #75833

Does this PR introduce a user-facing change?:

Update to use go 1.12.5

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 7, 2019
@cblecker
Copy link
Member Author

cblecker commented May 7, 2019

/hold
/sig release
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 7, 2019
@cblecker
Copy link
Member Author

cblecker commented May 7, 2019

/cc @wojtek-t @dims
/assign @javier-b-perez

@k8s-ci-robot k8s-ci-robot requested review from dims and wojtek-t May 7, 2019 02:39
@cblecker
Copy link
Member Author

cblecker commented May 7, 2019

Next steps:

  • Waiting for the docker hub image to publish. The PR is merged, so this should happen shortly.
  • Need a new version of the bazel rules_go to be published. (cc: @jayconrod)

@cblecker cblecker removed request for zmerlynn and luxas May 7, 2019 02:40
@cblecker cblecker mentioned this pull request May 7, 2019
Closed
@javier-b-perez
Copy link
Contributor

I still don't see the new golang image

@cblecker
Copy link
Member Author

cblecker commented May 7, 2019

@javier-b-perez Looks like the images are now published:

Digest: sha256:e52f9c9ea80fa182a78bd83a9f9e107d173b8e7fd922dbb0c60c8020a88fb7f6
Status: Downloaded newer image for golang:1.12.5

@javier-b-perez
Copy link
Contributor

/test pull-kubernetes-cross

@javier-b-perez
Copy link
Contributor

/LGTM
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
@wojtek-t
Copy link
Member

wojtek-t commented May 8, 2019

@cblecker - can you please update the sha in the PR?

@cblecker
Copy link
Member Author

cblecker commented May 8, 2019

@wojtek-t New rules_go hasn't been released yet: https://github.com/bazelbuild/rules_go/releases

@jayconrod: is there an ETA on the next cut?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
@cblecker
Copy link
Member Author

cblecker commented May 9, 2019

/hold cancel

All test are passing. This should be ready to ship. Looking for final review and LGTM.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2019
@dims
Copy link
Member

dims commented May 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@cblecker
Copy link
Member Author

cblecker commented May 9, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 851afa0 into kubernetes:master May 9, 2019
@cblecker cblecker deleted the go-1.12.5 branch May 9, 2019 16:37
@wojtek-t
Copy link
Member

Thanks a lot for this!

@nikhita nikhita mentioned this pull request May 13, 2019
Merged
@cblecker cblecker mentioned this pull request May 13, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request May 14, 2019
@k8s-ci-robot
Merge pull request #77831 from cblecker/automated-cherry-pick-of-#76576-
66049e3 
#77528-upstream-release-1.14

Automated cherry pick of #76576: Update to go 1.12.4 #77528: Update to go 1.12.5
justinsb added a commit to justinsb/kops that referenced this pull request May 19, 2019
@justinsb
Update go_version to 1.12.5
393e934 
Upstream change is kubernetes/kubernetes#77528
@justinsb justinsb mentioned this pull request May 19, 2019
Merged
justinsb added a commit to justinsb/kops that referenced this pull request May 19, 2019
@justinsb
Update go_version to 1.12.5
aac9fcb 
Upstream change is kubernetes/kubernetes#77528
justinsb added a commit to justinsb/kops that referenced this pull request May 19, 2019
@justinsb
Update go_version to 1.12.5
2085e15 
Upstream change is kubernetes/kubernetes#77528
justinsb added a commit to justinsb/kops that referenced this pull request May 19, 2019
@justinsb
Update go_version to 1.12.5
2550651 
Upstream change is kubernetes/kubernetes#77528
justinsb added a commit to justinsb/kops that referenced this pull request May 19, 2019
@justinsb
Update go_version to 1.12.5
f30e8cc 
Upstream change is kubernetes/kubernetes#77528
justinsb added a commit to justinsb/kops that referenced this pull request May 19, 2019
@justinsb
Update go_version to 1.12.5
099d6a7 
Upstream change is kubernetes/kubernetes#77528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@dims dims

@javier-b-perez javier-b-perez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API call latencies regressed due to upgrade to golang 1.12
5 participants
@cblecker @k8s-ci-robot @javier-b-perez @wojtek-t @dims