Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure Disk to csi-translation-lib #78330

Merged
merged 2 commits into from May 30, 2019

Conversation

@andyzhangx
Copy link
Member

commented May 25, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add support for Azure Disk to csi-translation-lib

in support of csi-migration proposal here: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md

Will help with migration of in-tree Azure Disk plugin to Azure Disk CSI.

Also see kubernetes/enhancements#625

Which issue(s) this PR fixes:

Fixes #76684

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add support for Azure Disk plugin to csi-translation-lib

/kind bug
/assign @feiskyer
/priority important-soon
/sig azure
/sig storage

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 25, 2019

/test pull-kubernetes-integration

@andyzhangx andyzhangx force-pushed the andyzhangx:csi-translation-azuredisk branch 2 times, most recently from 7e87952 to 822f4d0 May 25, 2019

Add support for Azure Disk to csi-translation-lib
rename to azure_disk

add more translation fields

fix typo

@andyzhangx andyzhangx force-pushed the andyzhangx:csi-translation-azuredisk branch from 822f4d0 to e65fba6 May 26, 2019

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 27, 2019

/assign @davidz627, @msau42

@feiskyer
Copy link
Member

left a comment

LGTM in general. Do we need a feature gate for it?

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

LGTM in general. Do we need a feature gate for it?

This is a general feature gate for this: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md#implementation-schedule

@feiskyer

This comment has been minimized.

Copy link
Member

commented May 28, 2019

/lgtm
/milestone v1.15

@k8s-ci-robot k8s-ci-robot added the lgtm label May 28, 2019

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 28, 2019

@feiskyer feiskyer added this to In progress in Provider Azure via automation May 28, 2019

@jsafrane

This comment has been minimized.

Copy link
Member

commented May 28, 2019

I am not migration expert, however I think there are couple of things missing:

  • You need to add azure into list of translated plugins here

  • Corresponding volume plugin should have IsMigratedToCSI filled, e.g. as in AWS. You need to create a new feature gate for each migrated plugin, so they can be migrated separately.

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 28, 2019

@jsafrane

This comment has been minimized.

Copy link
Member

commented May 28, 2019

lgtm the volume plugin part

/assign @ddebroy @davidz627
for the migration

add feature gate for azure disk
fix gofmt error

@andyzhangx andyzhangx force-pushed the andyzhangx:csi-translation-azuredisk branch from fbc52a9 to 6f2902e May 28, 2019

@davidz627

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label May 28, 2019

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-gce-csi-serial
/test pull-kubernetes-e2e-gce-device-plugin-gpu

@feiskyer
Copy link
Member

left a comment

/lgtm

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

/assign @saad-ali, could you approve? Thanks.

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

/test pull-kubernetes-e2e-gce-csi-serial

@jsafrane

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Saad is out of office,

@thockin, @liggitt, @childsb can you please approve a little feature? CSI migration requires a separate feature for each volume plugin, so we can migrate each at its own speed.

@liggitt

This comment has been minimized.

Copy link
Member

commented May 29, 2019

/approve
feature gate

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, davidz627, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8d5052e into kubernetes:master May 30, 2019

20 checks passed

cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

Provider Azure automation moved this from In progress to Done May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.