Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Azure Disk to csi-translation-lib #78330

Merged
merged 2 commits into from May 30, 2019
Merged

Add support for Azure Disk to csi-translation-lib #78330

merged 2 commits into from May 30, 2019

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add support for Azure Disk to csi-translation-lib

in support of csi-migration proposal here: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md

Will help with migration of in-tree Azure Disk plugin to Azure Disk CSI.

Also see kubernetes/enhancements#625

Which issue(s) this PR fixes:

Fixes #76684

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add support for Azure Disk plugin to csi-translation-lib

/kind bug
/assign @feiskyer
/priority important-soon
/sig azure
/sig storage

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/azure sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels May 25, 2019
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-integration

@andyzhangx andyzhangx force-pushed the csi-translation-azuredisk branch 2 times, most recently from 7e87952 to 822f4d0 Compare May 26, 2019 02:25
@andyzhangx
Add support for Azure Disk to csi-translation-lib
e65fba6 
rename to azure_disk

add more translation fields

fix typo
@andyzhangx
Copy link
Member Author

/assign @davidz627, @msau42

feiskyer
feiskyer reviewed May 27, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Do we need a feature gate for it?

@andyzhangx
Copy link
Member Author

LGTM in general. Do we need a feature gate for it?

This is a general feature gate for this: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md#implementation-schedule

@feiskyer
Copy link
Member

/lgtm
/milestone v1.15

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 28, 2019
@feiskyer feiskyer added this to In progress in Provider Azure via automation May 28, 2019
@jsafrane
Copy link
Member

I am not migration expert, however I think there are couple of things missing:

  • You need to add azure into list of translated plugins here

  • Corresponding volume plugin should have IsMigratedToCSI filled, e.g. as in AWS. You need to create a new feature gate for each migrated plugin, so they can be migrated separately.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2019
@jsafrane
Copy link
Member

lgtm the volume plugin part

/assign @ddebroy @davidz627
for the migration

@davidz627
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2019
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-gce-csi-serial
/test pull-kubernetes-e2e-gce-device-plugin-gpu

feiskyer
feiskyer reviewed May 29, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andyzhangx
Copy link
Member Author

/assign @saad-ali, could you approve? Thanks.

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-gce-csi-serial

@jsafrane
Copy link
Member

Saad is out of office,

@thockin, @liggitt, @childsb can you please approve a little feature? CSI migration requires a separate feature for each volume plugin, so we can migrate each at its own speed.

@liggitt
Copy link
Member

liggitt commented May 29, 2019

/approve
feature gate

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, davidz627, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8d5052e into kubernetes:master May 30, 2019
Provider Azure automation moved this from In progress to Done May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@davidz627 davidz627 Awaiting requested review from davidz627

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

Assignees

@feiskyer feiskyer

@davidz627 davidz627

@ddebroy ddebroy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Provider Azure
  
Done
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.

Add support for azure disk to csi-translation-lib
7 participants
@andyzhangx @feiskyer @jsafrane @davidz627 @liggitt @k8s-ci-robot @ddebroy