-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.14: Fix incorrect procMount defaulting #78883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
labels
Jun 11, 2019
k8s-ci-robot
added
the
do-not-merge/cherry-pick-not-approved
Indicates that a PR is not yet approved to merge into a release branch.
label
Jun 11, 2019
k8s-ci-robot
added
sig/apps
Categorizes an issue or PR as relevant to SIG Apps.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
priority/critical-urgent
Highest priority. Must be actively worked on as someone's top priority right now.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
needs-kind
Indicates a PR lacks a `kind/foo` label and requires one.
area/test
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
labels
Jun 11, 2019
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jun 11, 2019
liggitt
changed the title
WIP - Fix incorrect procMount defaulting
Fix incorrect procMount defaulting
Jun 11, 2019
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jun 11, 2019
/kind bug |
k8s-ci-robot
added
kind/bug
Categorizes issue or PR as related to a bug.
and removed
needs-kind
Indicates a PR lacks a `kind/foo` label and requires one.
labels
Jun 11, 2019
liggitt
changed the title
Fix incorrect procMount defaulting
1.14: Fix incorrect procMount defaulting
Jun 11, 2019
/milestone v1.14 |
janetkuo
approved these changes
Jun 11, 2019
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jun 11, 2019
tpepper
added
the
cherry-pick-approved
Indicates a cherry-pick PR into a release branch has been approved by the release branch manager.
label
Jun 20, 2019
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
Indicates that a PR is not yet approved to merge into a release branch.
label
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/test
cherry-pick-approved
Indicates a cherry-pick PR into a release branch has been approved by the release branch manager.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/critical-urgent
Highest priority. Must be actively worked on as someone's top priority right now.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/apps
Categorizes an issue or PR as relevant to SIG Apps.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes incorrect forcing of the alpha procMount field to a non-nil value.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):xref #78633
See similar discussion around impact of defaulting fields within pod spec on workload controllers in #69988 and #69445.
Special notes for your reviewer:
This PR restores the behavior for this alpha field to the way it was in 1.12 and 1.13, with one change: objects without the alpha field set are allowed to remain nil. This prevents unrelated updates to a workload object (like annotating it) from modifying the pod spec portion of the object and forcing a spurious rollout.
This also updates the fixtures used in the workload upgrade tests that would have caught this issue.
Similar changes are required in 1.12 and 1.13.
Release note:
/sig apps
/cc @janetkuo @smarterclayton
/priority critical-urgent