Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #79326: fix: Use correct function to remove etcd member #79331

Merged
merged 1 commit into from Jun 24, 2019
Merged

Automated cherry pick of #79326: fix: Use correct function to remove etcd member #79331

merged 1 commit into from Jun 24, 2019

Conversation

draveness
Copy link
Contributor

What type of PR is this?
/kind bug
/priority critical-urgent

What this PR does / why we need it:

This uses the correct function name for removing the etcd member from the cluster during a kubeadm reset.

Which issue(s) this PR fixes:

ref: #79326

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix remove the etcd member from the cluster during a kubeadm reset.

@bradbeam @draveness
fix: Use correct function to remove etcd member
915ae25 
Signed-off-by: Brad Beam <brad.beam@talos-systems.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 24, 2019
@draveness
Copy link
Contributor Author

/sig cluster-lifecycle

cc/ @bradbeam @rosti

@draveness draveness changed the title fix: Use correct function to remove etcd member Automated cherry pick of #79326: fix: Use correct function to remove etcd member Jun 24, 2019
@draveness
Copy link
Contributor Author

/assign @Bubblemelon @rosti @luxas

rosti
rosti approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cherry-pick @draveness !
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2019
@draveness
Copy link
Contributor Author

flaky test

/retest

@draveness
Copy link
Contributor Author

@kubernetes/patch-release-team

@neolit123
Copy link
Member

/milestone v1.15

@kubernetes/sig-release
https://github.com/kubernetes/sig-release/blob/master/releases/release-1.15/release_team.md
doesn't say who the patch manager is?
thanks.

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Jun 24, 2019
@draveness
Copy link
Contributor Author

/milestone v1.15

@kubernetes/sig-release
https://github.com/kubernetes/sig-release/blob/master/releases/release-1.15/release_team.md
doesn't say who the patch manager is?
thanks.

I met the same problem, so I pinged the patch release team which seems the right team to respond.

@feiskyer
Copy link
Member

Ping the patch-release-team team would work.

@feiskyer feiskyer removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 24, 2019
@feiskyer feiskyer added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 24, 2019
@neolit123
Copy link
Member

Ping the patch-release-team team would work.

got it now -> @kubernetes/patch-release-team

@k8s-ci-robot k8s-ci-robot merged commit 5b2266b into kubernetes:release-1.15 Jun 24, 2019
@draveness draveness deleted the automated-cherry-pick-of-#79326-upstream-release-1.15 branch June 24, 2019 15:30
This was referenced Jun 28, 2019
Closed
Closed
@staticdev
Copy link

I am not used to kubeadm internals but I am having an issue with preflight-check error:
[ERROR DirAvailable--var-lib-etcd]: /var/lib/etcd is not empty

Does this merged change takes this preflight-check away? Can I safely skip these checks?

@SataQiu SataQiu mentioned this pull request Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosti rosti rosti approved these changes

@chuckha chuckha Awaiting requested review from chuckha

@yagonobre yagonobre Awaiting requested review from yagonobre

Assignees

@rosti rosti

@luxas luxas

@Bubblemelon Bubblemelon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@draveness @k8s-ci-robot @neolit123 @feiskyer @staticdev @rosti @luxas @Bubblemelon @bradbeam