Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiextensions: wire structural schema into server-side-apply #79433

Closed
wants to merge 11 commits into from
Closed

apiextensions: wire structural schema into server-side-apply #79433

wants to merge 11 commits into from

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jun 26, 2019 •
edited
Loading

Based on @jennybuckley's #77354 and includes #74133.

TODO:

  • reject server-side-apply requests for non-structural CRDs
  • test that server-side-apply patches are reject for non-structural CRDs
CustomResourceDefinition with structural schema get support for server-side apply.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 26, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 26, 2019
@sttts
Copy link
Contributor Author

sttts commented Jun 26, 2019

@jennybuckley fyi, started with this now. Still WIP based on your PR.

@sttts sttts added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 26, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 26, 2019
@sttts sttts added this to the v1.16 milestone Jun 26, 2019
@fedebongio
Copy link
Contributor

/assign @jennybuckley

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2019
@sttts sttts mentioned this pull request Jul 13, 2019
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2019
@jennybuckley jennybuckley mentioned this pull request Aug 6, 2019
Closed
@josiahbjorgaard
Copy link
Contributor

Hello! I'm a bug triage shadow for the 1.16 release cycle and considering this PR has not been updated for a long time, I'd like to check it's status. The code freeze is starting 29th August (about 2 weeks from now) and while there is plenty of time, we want to ensure that each PR has a chance to be merged on time.

As the PR is tagged for 1.16, is it still planned for this release?

@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 15, 2019
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sttts
To complete the pull request process, please assign thockin
You can assign the PR to them by writing /assign @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts sttts changed the title WIP: apiextensions: wire structural schema into server-side-apply apiextensions: wire structural schema into server-side-apply Aug 15, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sttts sttts force-pushed the sttts-ssa-wiring branch 5 times, most recently from 2815421 to 28f2b96 Compare August 22, 2019 21:46
@k8s-ci-robot
Copy link
Contributor

@sttts: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration 06fce41 link /test pull-kubernetes-integration
pull-kubernetes-typecheck 06fce41 link /test pull-kubernetes-typecheck
pull-kubernetes-node-e2e 06fce41 link /test pull-kubernetes-node-e2e
pull-kubernetes-cross 06fce41 link /test pull-kubernetes-cross
pull-kubernetes-node-e2e-containerd 06fce41 link /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-bazel-test 06fce41 link /test pull-kubernetes-bazel-test
pull-kubernetes-verify 06fce41 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Member

liggitt commented Aug 31, 2019

was this replaced by #77354?

@liggitt
Copy link
Member

liggitt commented Sep 5, 2019

was this replaced by #77354?

spoke offline, this isn't needed after #77354

/close

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closed this PR.

In response to this:

was this replaced by #77354?

spoke offline, this isn't needed after #77354

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@kwiesmueller kwiesmueller Awaiting requested review from kwiesmueller

Assignees

@jennybuckley jennybuckley

Labels
area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
7 participants
@sttts @fedebongio @josiahbjorgaard @k8s-ci-robot @fejta-bot @liggitt @jennybuckley