Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #79245: kunsupported cgroup setup causes kubelet to emit a warning #80121

Merged
merged 1 commit into from Sep 13, 2019
Merged

Automated cherry pick of #79245: kunsupported cgroup setup causes kubelet to emit a warning #80121

merged 1 commit into from Sep 13, 2019

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jul 13, 2019

Cherry pick of #79245 on release-1.15.

#79245: kunsupported cgroup setup causes kubelet to emit a warning

Release note

Fixed possible kubelet stop because of non unified CPU and memory cgroup hierarchy.

@k8s-ci-robot
Copy link
Contributor

@saschagrunert: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please ping the kubernetes/patch-release-team in a comment when ready.

See also Kubernetes Patch Releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 13, 2019
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 13, 2019
@saschagrunert
Copy link
Member Author

saschagrunert commented Jul 13, 2019

Do you think we can change the release notes to something like:

Fixed possible kubelet stop because of non unified CPU and memory cgroup hierarchy.

Relates to: #80090

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-kubernetes-kubemark-e2e-gce-big
/lgtm

+1 to the note around updating the release note.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2019
@saschagrunert
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

1 similar comment
@saschagrunert
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

Hey @kubernetes/sig-release 👋 do you see a way to get this into the next 1.15 patch release?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 6, 2019
@tpepper
Copy link
Member

tpepper commented Aug 6, 2019

/kind bug
/priority important-soon
@kubernetes/sig-node-pr-reviews looking for ya'll's approval on this cherry pick

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 6, 2019
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 6, 2019
@derekwaynecarr
Copy link
Member

It would help to understand in the future why we felt this change had to be cherry-picked. Production systems should run a unified hierarchy. If its to support testing 1.15 w/ hack/local-up-cluster that is fine, but Kubernetes systems should run unified hierarchy.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2019
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 13, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4d77e52 into kubernetes:release-1.15 Sep 13, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Sep 13, 2019
@saschagrunert saschagrunert deleted the automated-cherry-pick-of-#79245-upstream-release-1.15 branch September 14, 2019 06:43
@VR-Architect
Copy link

I am getting this error on version 1.22.0

@VR-Architect
Copy link

This fixed the error from showing for me. Change Docker from cgroupfs to systemd. Would this be good to add to the docs as a step for installation to do this?

Of course, now I have a different error regarding the cni config uninitialized, but that's a different issue.

create a file /etc/docker/daemon.json
{
"exec-opts": ["native.cgroupdriver=systemd"]
}
reference: https://stackoverflow.com/questions/43794169/docker-change-cgroup-driver-to-systemd

reference: #80121

@saschagrunert
Copy link
Member Author

@VR-Architect yeah the systemd cgroup driver should be preferred over cgroupfs. Unfortunately docker shim got deprecated a while ago, but having the information in the docs should be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants