Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominate alculquicondor to scheduler reviewers #82500

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Nominate alculquicondor to scheduler reviewers #82500

merged 1 commit into from
Sep 12, 2019
+1 −0

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Sep 9, 2019 •
edited
Loading

/kind documentation
/sig scheduling

I'm nominating myself for sig-scheduling reviewers.
I have submitted 11 PRs and reviewed 12 PRs.

I've been the primary reviewer of #81876, #80696 (framework), #81068, #80395, #79631 (even pod spreading) and #80696 (cleanup).

cc/ @Huang-Wei @ahg-g

NONE

@alculquicondor
Nominate alculquicondor to scheduler reviewers
5af048a 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 9, 2019
@alculquicondor
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@Huang-Wei
Copy link
Member

+100 on supporting @alculquicondor to become the sig-scheduling reviewer.

@ahg-g
Copy link
Member

ahg-g commented Sep 9, 2019

/lgtm

Thanks Aldo for all your contributions so far, I strongly support this proposal.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2019
@alculquicondor
Copy link
Member Author

Thanks for the support!

/assign @smarterclayton

@alculquicondor
Copy link
Member Author

/assign @liggitt
/unassign @smarterclayton

@liggitt
Copy link
Member

liggitt commented Sep 12, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 12, 2019
@Huang-Wei
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit f674747 into kubernetes:master Sep 12, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 12, 2019
@ahg-g ahg-g mentioned this pull request Jan 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
6 participants
@alculquicondor @Huang-Wei @ahg-g @liggitt @k8s-ci-robot @smarterclayton