Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Promote "CSI volume limit information using mock driver should report attach limit when limit is bigger than 0" e2e test to Conformance #85164

Closed
wants to merge 1 commit into from
Closed

WIP: Promote "CSI volume limit information using mock driver should report attach limit when limit is bigger than 0" e2e test to Conformance #85164

wants to merge 1 commit into from

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Nov 13, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
CSINode API and volume attach limit feature is GA in 1.17. Promote the test case using CSI mock driver to conformance. This test case only tests K8s API + controller behavior, not any data capabilities of the driver. The CSI mock driver is very lightweight and doesn't require any of the standard privileges that a real CSI driver requires.

Which issue(s) this PR fixes:

Fixes #
Part of #85101

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 13, 2019
@msau42
Copy link
Member Author

msau42 commented Nov 13, 2019

/area conformance
@kubernetes/sig-architecture-pr-reviews @kubernetes/sig-storage-pr-reviews @kubernetes/cncf-conformance-wg

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/conformance Issues or PRs related to kubernetes conformance tests sig/storage Categorizes an issue or PR as relevant to SIG Storage. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 13, 2019
@msau42
Copy link
Member Author

msau42 commented Nov 13, 2019

https://k8s-testgrid.appspot.com/sig-storage-kubernetes#gce-slow&include-filter-by-regex=mock.*volume%20limit

@msau42
Copy link
Member Author

msau42 commented Nov 13, 2019

/test pull-kubernetes-e2e-aks-engine-azure-windows

@msau42 msau42 added this to To Triage in conformance-definition Nov 13, 2019
@spiffxp spiffxp moved this from To Triage to In Progress in conformance-definition Jan 10, 2020
@spiffxp
Copy link
Member

spiffxp commented Jan 10, 2020

/retest

@spiffxp
Copy link
Member

spiffxp commented Jan 10, 2020

/lgtm
FWIW I'm not sure this test needs to be tagged as [Slow], it consistently runs in less than 5 minutes
https://testgrid.k8s.io/sig-release-master-informing#gce-cos-master-slow&include-filter-by-regex=CSI%20volume%20limit&graph-metrics=test-duration-minutes&width=5

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@spiffxp spiffxp moved this from In Progress to Needs Approval in conformance-definition Jan 10, 2020
@msau42
Copy link
Member Author

msau42 commented Jan 10, 2020

/hold
apparently even mock driver needs to run as privileged in order to create the unix domain socket that communicates with kubelet on selinux systems.

This may pose a problem for conformance as I believe privileged pods are currently not allowed? Is there a reason why?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2020
@hh hh moved this from Needs Approval to Needs Review in conformance-definition Jan 15, 2020
@hh
Copy link
Member

hh commented Feb 11, 2020

/assign @johnbelamaric

johnbelamaric
johnbelamaric reviewed Feb 21, 2020
View reviewed changes
test/e2e/storage/csi_mock_volume.go Outdated
@@ -382,7 +382,13 @@ var _ = utils.SIGDescribe("CSI mock volume", func() {
})

ginkgo.Context("CSI volume limit information using mock driver", func() {
ginkgo.It("should report attach limit when limit is bigger than 0 [Slow]", func() {
/*
Release : v1.17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.18

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2020
@msau42
Copy link
Member Author

msau42 commented Sep 15, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2020
@spiffxp
Copy link
Member

spiffxp commented Nov 5, 2020

needs rebase

@msau42
Copy link
Member Author

msau42 commented Nov 5, 2020

Yes, unfortunately we're waiting on a bug fix to fix this flaky test before we can promote to conformance. It does not look like it's on track to make 1.20: #84206

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 5, 2021
@spiffxp
Copy link
Member

spiffxp commented Mar 9, 2021

/remove-lifecycle rotten
The fix landed. Do you want to try for this for v1.21 by test freeze?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 9, 2021
@msau42
Copy link
Member Author

msau42 commented Mar 9, 2021

The fix landed but got reverted :( #96758 So unfortunately this won't make 1.21.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 7, 2021
@msau42
Copy link
Member Author

msau42 commented Jul 7, 2021

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 7, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 5, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 4, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

conformance-definition automation moved this from In Progress PRs to Done Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric johnbelamaric left review comments

@gnufied gnufied Awaiting requested review from gnufied

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@spiffxp spiffxp

@johnbelamaric johnbelamaric

Labels
area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
conformance-definition
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@msau42 @spiffxp @hh @johnbelamaric @bertinatto @k8s-ci-robot @riaankleinhans @fejta-bot @k8s-triage-robot