Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ping kmsplugin gentely when in good state #85828

Open
wants to merge 1 commit into
base: master
from

Conversation

@shihan9
Copy link
Contributor

shihan9 commented Dec 3, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
too many calls to kms when kms provider in good state

NONE
``
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 3, 2019

@shihan9: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 3, 2019

Hi @shihan9. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shihan9

This comment has been minimized.

Copy link
Contributor Author

shihan9 commented Dec 3, 2019

@@ -48,6 +48,7 @@ const (
kmsTransformerPrefixV1 = "k8s:enc:kms:v1:"
kmsPluginConnectionTimeout = 3 * time.Second
kmsPluginHealthzTTL = 3 * time.Second

This comment has been minimized.

Copy link
@immutableT

immutableT Dec 3, 2019

Contributor

Let's rename this to kmsPluginHealthzNegativeTTL.

This comment has been minimized.

Copy link
@shihan9

shihan9 Dec 3, 2019

Author Contributor

Done

@immutableT

This comment has been minimized.

Copy link
Contributor

immutableT commented Dec 3, 2019

/ok-to-test

@RA489

This comment has been minimized.

Copy link
Contributor

RA489 commented Dec 3, 2019

/retest

@RA489

This comment has been minimized.

Copy link
Contributor

RA489 commented Dec 3, 2019

/release-note-none

@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Dec 3, 2019

/assign @lavalamp

Change-Id: I50ce249d7996e5c51dcbb00e53d67300aa72a87f
@shihan9 shihan9 force-pushed the shihan9:master branch from 87f6dea to e7352bb Dec 3, 2019
@k8s-ci-robot k8s-ci-robot added size/M and removed size/XS labels Dec 3, 2019
@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented Dec 4, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, shihan9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 4, 2019

@shihan9: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration e7352bb link /test pull-kubernetes-integration
pull-kubernetes-e2e-gce e7352bb link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -261,6 +275,31 @@ func TestKMSPluginHealthz(t *testing.T) {
}
}

func TestKMSPluginHealthzTTL(t *testing.T) {

This comment has been minimized.

Copy link
@immutableT

immutableT Dec 4, 2019

Contributor

convert this to table-driven test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.