Fix broken SELinux detection #86027
Merged
Fix broken SELinux detection #86027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
The upgrade of dependencies in kubernetes#78187 introduced a regression in detecting if SELinux is enabled or not. As the library requires the golang build tag `selinux` to be enabled after that version update. Fixes bug report kubernetes#83679
simonswine
force-pushed
the
fix-selinux-detection
branch
from
ffcb4a3
to
24d1059
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
lgtm
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/lgtm @kubernetes/patch-release-team @guineveresaenger This should get CP'd into 1.16/1.17 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, dims, simonswine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Dec 8, 2019
|
I would like to see a test added that would have caught this regression. |
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 12, 2019
…027-upstream-release-1.17 Automated cherry pick of #86027: Fix broken SELinux detection
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 16, 2019
…027-upstream-release-1.16 Automated cherry pick of #86027: Fix broken SELinux detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade of dependencies in #78187 introduced a regression in
detecting if SELinux is enabled or not. As the library requires
the golang build tag
selinuxto be enabled after that version update.What type of PR is this?
/kind bug
What this PR does / why we need it:
The dependency update PR #78187 broke SELinux detection
All versions since that change have problems starting pods on SELinux enabled hosts
Which issue(s) this PR fixes:
Fixes #83679
Special notes for your reviewer:
I am not too much of an bazel/gazelle expert and I am not too sure what other implications my changes might have.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
51177c1
Before regression: https://github.com/opencontainers/selinux/blob/4a2974bf1ee960774ffd517717f1f45325af0206/go-selinux/selinux.go#L1
With regression, requiring the build tag: https://github.com/opencontainers/selinux/blob/v1.2.2/go-selinux/selinux_linux.go#L1