Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #86027: Fix broken SELinux detection #86036

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Automated cherry pick of #86027: Fix broken SELinux detection #86036

merged 1 commit into from
Dec 16, 2019

Conversation

idealhack
Copy link
Member

Cherry pick of #86027 on release-1.16.

#86027: Fix broken SELinux detection

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot
Copy link
Contributor

@idealhack: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #86027.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@idealhack idealhack force-pushed the automated-cherry-pick-of-#86027-upstream-release-1.16 branch from 891d6bb to f8fa01d Compare December 8, 2019 13:54
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 8, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Dec 8, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2019
@k8s-ci-robot
Copy link
Contributor

@idealhack: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 8, 2019
@idealhack
Copy link
Member Author

/kind bug
/priority important-soon
/sig architecture
/sig node
/sig storage
/release-note-none

/assign @cblecker @liggitt

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 8, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 8, 2019
@idealhack
Copy link
Member Author

/test pull-kubernetes-cross

@idealhack
Copy link
Member Author

/test pull-kubernetes-verify

@cblecker
Copy link
Member

cblecker commented Dec 8, 2019

@idealhack You may need to re-run hack/update-bazel.sh on this PR.

@idealhack idealhack force-pushed the automated-cherry-pick-of-#86027-upstream-release-1.16 branch from f8fa01d to 6e9cebc Compare December 9, 2019 03:48
@idealhack
Copy link
Member Author

@cblecker thanks, the test is now passing.

in the meantime...
/test pull-kubernetes-e2e-gce

@cblecker
Copy link
Member

cblecker commented Dec 9, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 9, 2019
@justaugustus
Copy link
Member

/hold pending next patch release

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2019
@idealhack idealhack added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 12, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 12, 2019
@idealhack
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2019
@idealhack
Copy link
Member Author

/retest

@simonswine @idealhack
Fix broken SELinux detection
dae379c 
The upgrade of dependencies in kubernetes#78187 introduced a regression in
detecting if SELinux is enabled or not. As the library requires
the golang build tag `selinux` to be enabled after that version update.

Fixes bug report kubernetes#83679
@idealhack idealhack force-pushed the automated-cherry-pick-of-#86027-upstream-release-1.16 branch from 6e9cebc to dae379c Compare December 12, 2019 05:27
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2019
@idealhack
Copy link
Member Author

not sure why, but hack/update-openapi-spec.sh (suggested by pull-kubernetes-verify) gave me:

diff --git a/api/openapi-spec/swagger.json b/api/openapi-spec/swagger.json
index dfee4e9..5338ecd 100644
--- a/api/openapi-spec/swagger.json
+++ b/api/openapi-spec/swagger.json
@@ -20106,7 +20106,7 @@
   },
   "info": {
     "title": "Kubernetes",
-    "version": "v1.16.5"
+    "version": "v1.12.0"
   },
   "paths": {
     "/api/": {

@liggitt
Copy link
Member

liggitt commented Dec 12, 2019

@idealhack You need to fetch tags from the kubernetes repo

@liggitt
Copy link
Member

liggitt commented Dec 12, 2019

cc @tpepper on openapi version being incorrect

@idealhack you shouldn't need to change that as part of this PR. There's an open issue about the release branches getting the wrong version generated.

@superseb superseb mentioned this pull request Dec 12, 2019
Closed
@justaugustus
Copy link
Member

/retest

@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, idealhack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

4 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 235812e into kubernetes:release-1.16 Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@idealhack @k8s-ci-robot @cblecker @justaugustus @liggitt @fejta-bot @simonswine