Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in kubelet getMountedVolumePathListFromDisk #87166

Open
wants to merge 1 commit into
base: master
from

Conversation

@jingxu97
Copy link
Contributor

jingxu97 commented Jan 13, 2020

This PR fixes issue #74650. It adds the extra check for /mount dir under
pod volume dir. It also adds the unit test for this function

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #74650

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 13, 2020

@jingxu97: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 13, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jingxu97
To complete the pull request process, please assign vishh
You can assign the PR to them by writing /assign @vishh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingxu97 jingxu97 force-pushed the jingxu97:Jan/mountcheckfix branch 2 times, most recently from 93fae09 to 5dd339a Jan 13, 2020
@jingxu97

This comment has been minimized.

Copy link
Contributor Author

jingxu97 commented Jan 16, 2020

/test pull-kubernetes-integration

@jingxu97

This comment has been minimized.

Copy link
Contributor Author

jingxu97 commented Jan 16, 2020

/test pull-kubernetes-e2e-gce

@jingxu97 jingxu97 requested a review from msau42 Jan 16, 2020
@jingxu97

This comment has been minimized.

Copy link
Contributor Author

jingxu97 commented Jan 16, 2020

cc @msau42

pkg/kubelet/kubelet_getters.go Outdated Show resolved Hide resolved
@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jan 16, 2020

@jingxu97 jingxu97 force-pushed the jingxu97:Jan/mountcheckfix branch from 5dd339a to fbaba72 Jan 16, 2020
@jingxu97

This comment has been minimized.

Copy link
Contributor Author

jingxu97 commented Jan 17, 2020

/retest

This PR fixes issue #74650. It adds the extra check for /mount dir under
pod volume dir. It also adds the unit test for this function
@jingxu97 jingxu97 force-pushed the jingxu97:Jan/mountcheckfix branch from fbaba72 to e61fbb5 Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.