Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to docker command line in tests/e2e_node #87335

Merged
merged 1 commit into from
Jan 21, 2020
Merged

switch to docker command line in tests/e2e_node #87335

merged 1 commit into from
Jan 21, 2020

Conversation

dims
Copy link
Member

@dims dims commented Jan 17, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Avoid references to docker/docker code and use the command line instead.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 17, 2020
@dims
Copy link
Member Author

dims commented Jan 17, 2020

/sig testing
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 17, 2020
@dims
Copy link
Member Author

dims commented Jan 17, 2020

/assign @yujuhong

@dims
Copy link
Member Author

dims commented Jan 17, 2020

/assign @oomichi

@dims
Copy link
Member Author

dims commented Jan 17, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-kubemark-e2e-gce-big

oomichi
oomichi reviewed Jan 18, 2020
View reviewed changes
test/e2e_node/docker_util.go Outdated
if err != nil {
return info, fmt.Errorf("failed to create docker client: %v", err)
return "", fmt.Errorf("failed to get docker server version: %v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here should be failed to get docker info instead.
I guess the line came from line 31 ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops! fixed.

@dims dims force-pushed the remove-docker/docker-references-from-tests branch from fda33e0 to d7d316e Compare January 18, 2020 02:08
neolit123
neolit123 reviewed Jan 18, 2020
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2020
@dims
Copy link
Member Author

dims commented Jan 19, 2020

@oomichi it's ready now.

@oomichi
Copy link
Member

oomichi commented Jan 20, 2020

Thanks for updating,

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@dims
Copy link
Member Author

dims commented Jan 20, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 98186e0 into kubernetes:master Jan 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@oomichi oomichi oomichi left review comments

@dashpole dashpole Awaiting requested review from dashpole

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@neolit123 neolit123

@oomichi oomichi

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
6 participants
@dims @oomichi @k8s-ci-robot @fejta-bot @neolit123 @yujuhong