Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate Ingress to V1 #1453

Closed
robscott opened this issue Jan 14, 2020 · 34 comments
Closed

Graduate Ingress to V1 #1453

robscott opened this issue Jan 14, 2020 · 34 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@robscott
Copy link
Member

robscott commented Jan 14, 2020

/sig network
/assign

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jan 14, 2020
@robscott
Copy link
Member Author

robscott commented Jan 14, 2020

/cc @bowei

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jan 15, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 15, 2020
@kikisdeliveryservice kikisdeliveryservice added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 15, 2020
@cmluciano
Copy link
Member

cmluciano commented Jan 15, 2020

/assign

@robscott robscott added this to In progress in SIG-Network KEPs Jan 25, 2020
@liggitt liggitt added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 30, 2020
@VineethReddy02
Copy link

VineethReddy02 commented Feb 5, 2020

Hello, @robscott, I'm 1.18 docs lead.
Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@robscott
Copy link
Member Author

robscott commented Feb 6, 2020

Hey @VineethReddy02, this will require some additions to the Ingress docs. I'll have placeholder docs PR in place by Feb 28.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Feb 10, 2020

Hi @robscott @cmluciano !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement?

Thanks!
The 1.18 Enhancements Team

@cmluciano
Copy link
Member

cmluciano commented Feb 10, 2020

Hi we have a few that are being reviewed in a different branch that will be combined into a large PR on k/k.

Rollup PR kubernetes/kubernetes#88041

@VineethReddy02
Copy link

VineethReddy02 commented Feb 21, 2020

Hello @robscott
We are close to the docs placeholder PR deadline against the dev-1.18 branch. Having a placeholder PR in place will definitely help us in tracking enhancements much better.

Thanks! :)

@cmluciano
Copy link
Member

cmluciano commented Feb 21, 2020

@VineethReddy02 I'll be starting the docs today and will link the placeholder PR here.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Feb 24, 2020

@cmluciano @robscott

Reminder, we are getting close to code freeze on 05 March 2020. It looks like you still have some open PRs fort his. Are you confident these will get merged by code freeze?

@robscott
Copy link
Member Author

robscott commented Feb 24, 2020

Hey @jeremyrickard, we are limiting the scope of what we'll be part of 1.18 (staying at v1beta1 until 1.19), but we are confident that we'll get what we've committed to in.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Mar 2, 2020

Hi @robscott can you update the first message of this enhancement to indicate that 1.18 is beta and 1.19 is the intended stable?

@robscott
Copy link
Member Author

robscott commented Mar 2, 2020

@kikisdeliveryservice Just updated, thanks for catching that!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Mar 2, 2020

Thank you, @robscott ! :)

@kikisdeliveryservice kikisdeliveryservice added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label May 4, 2020
@savitharaghunathan
Copy link
Member

savitharaghunathan commented May 21, 2020

Hi @robscott @cmluciano - I am Savitha, 1.19 Docs lead. Does this enhancement work planned for 1.19 require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder we're looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

@robscott
Copy link
Member Author

robscott commented May 21, 2020

Hey @savitharaghunathan, thanks for checking in! This feature will need some docs updates. I'll make sure we get a placeholder PR in place by June 12.

@savitharaghunathan
Copy link
Member

savitharaghunathan commented May 26, 2020

Thank you for the update, @robscott :)

@wojtek-t
Copy link
Member

wojtek-t commented May 27, 2020

@robscott @bowei - can you please

  1. transform the KEP to the new format (should be simple, just extracting metadata to kep.yaml: see template: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template )
  2. fill in PRR questionaire and assign me as PRR approver (I'm taking all network PRRs this cycle)

@cmluciano
Copy link
Member

cmluciano commented May 27, 2020

@robscott I can work on this today and carry over the timeline updates from a WIP PR.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 28, 2020

Hi @robscott

As a reminder that the Code Freeze is June 25th. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement? I see that 88587 merged in March, do you anticipate needing other PRs to finish this enhancement?

Thanks!
The 1.19 Enhancements Team

@cmluciano
Copy link
Member

cmluciano commented May 28, 2020

@kikisdeliveryservice Yes we still need the following PRs merged:

we also have graduation criteria updated in #1826

@savitharaghunathan
Copy link
Member

savitharaghunathan commented Jun 1, 2020

Hi @robscott, just a reminder that placeholder PR is due by June 12th. Once you have it in place, please provide a link to the PR. If you already have one against dev-1.19 branch, can you link the PR here?

@robscott
Copy link
Member Author

robscott commented Jun 8, 2020

Hey @savitharaghunathan, thanks for the reminder! I've added a docs PR for this feature here: kubernetes/website#21590

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jun 15, 2020

Hi @robscott !

To follow-up on the email sent to k-dev today, I wanted to let you know that Code Freeze has been extended to Thursday, July 9th. You can see the revised schedule here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.19

We expect all PRs to be merged by that time. Please let me know if you have any questions. 😄

Best,
Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jul 1, 2020

@kikisdeliveryservice Yes we still need the following PRs merged:

* [x]  API changes [kubernetes/kubernetes#89778](https://github.com/kubernetes/kubernetes/pull/89778)

* [x]  kubectl changes [kubernetes/kubernetes#91268](https://github.com/kubernetes/kubernetes/pull/91268)

* [x]  CRUD e2e tests for Ingress suitable for conformance promotion (WIP)

* [x]  CRUD e2e tests for IngressClass suitable for conformance promotion (WIP)

we also have graduation criteria updated in #1826

Looks like this is now code complete - all 4 PRs have merged.
Awesome work @cmluciano !

@cmluciano
Copy link
Member

cmluciano commented Jul 1, 2020

Thanks @kikisdeliveryservice . Yes we are code complete, the only thing left to merge are the docs under kubernetes/website#21590 .

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 11, 2020

Hi @robscott @cmluciano !

Enhancements lead here. Everything was completed for stable in 1.19. One last thing can you please update the KEP and mark it as implemented?

After that's merged and done we can close this issue.

Thanks and congrats!!
Kirsten

@kikisdeliveryservice kikisdeliveryservice removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 11, 2020
@robscott
Copy link
Member Author

robscott commented Sep 30, 2020

Hey @kikisdeliveryservice, sorry we missed this! It looks like this KEP already has the status set to implemented, do we need to update anything else? https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/1453-ingress-api/kep.yaml#L9

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 30, 2020

Nope! Feel free to close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests

10 participants