Fix flaws in Azure CSI translation

[rfranzke]

What type of PR is this?
/kind bug

What this PR does / why we need it:
The Azure File CSI translation was not setting the DriverName field, eventually causing the attachdetach-controller to fail when CSI migration is enabled:

kubernetes.io/csi: attacher.Attach failed: VolumeAttachment.storage.k8s.io \"csi-19e8c8fd3545d41cebf6a51ffebcdd8588df8c5bfb9bd085b1689e7ca6704c59\" is invalid: [spec.attacher: Required value, spec.attacher: Invalid value: \"\": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')]"

I implemented some unit tests for Azure along the way.

Does this PR introduce a user-facing change?:

Fix flaws in Azure File CSI translation

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Part of kubernetes/enhancements#1490

[k8s-ci-robot]

Hi @rfranzke. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ialidzhikov]

Nits

[rfranzke]

/assign @andyzhangx @feiskyer @saad-ali
/sig storage
/area provider/azure
/priority important-soon

[andyzhangx]

/ok-to-test

[andyzhangx]

@rfranzke thanks for your contribution!

[rfranzke]

/test pull-kubernetes-e2e-gce

[andyzhangx]

/assign @msau42 @davidz627
could you approve? thanks.

[andyzhangx]

/hold
hold a while for new commits on azure file csi migration issue

[andyzhangx]

/hold cancel

[andyzhangx]

This PR would require following components change(adopt the PR) to make azure file csi migration works:

• kube-controller-manager
• kubelet
• csi-provisioner
• csi-attacher

And only works with azure file csi driver on master branch (with PR merged)

[msau42]

/approve

[msau42]

Is this a normal condition? Should it fail instead?

[andyzhangx]

in such condition, secret is spedified by user, so it does not obey the naming rule, and this is only for volumeid generation, we will use NodeStageSecret for secret passing:

						NodeStageSecretRef: &v1.SecretReference{
							Name:      azureSource.SecretName,
							Namespace: defaultSecretNamespace,
						},

[msau42]

And only works with azure file csi driver on master branch (with PR merged)

What happens if you run the new translation library against an older driver?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, msau42, rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/csi-translation-lib/OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

And only works with azure file csi driver on master branch (with PR merged)

What happens if you run the new translation library against an older driver?

there is a little refactor in azure file csi driver, let's only support new driver. Since it's still alpha, it's ok to be not backward compatible.

[andyzhangx]

/lgtm

[rfranzke]

/retest