Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote HugePageStorageMediumSize feature to Beta #90592

Merged
merged 1 commit into from
Jun 21, 2020
Merged

Promote HugePageStorageMediumSize feature to Beta #90592

merged 1 commit into from
Jun 21, 2020

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Apr 29, 2020 •
edited
Loading

What type of PR is this?

/kind api-change

What this PR does / why we need it:

This change promotes HugePageStorageMediumSize feature to Beta and enables support for multiple size huge pages by default.

Does this PR introduce a user-facing change?:

The HugePageStorageMediumSize feature gate is now on by default allowing usage of multiple sizes huge page resources on a container level.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 29, 2020
@bart0sh
Copy link
Contributor Author

bart0sh commented Apr 29, 2020

/assign @liggitt

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@bart0sh
Copy link
Contributor Author

bart0sh commented Apr 29, 2020

/retest

@liggitt liggitt requested review from derekwaynecarr and removed request for lavalamp and brendandburns April 29, 2020 16:24
@liggitt liggitt assigned derekwaynecarr and unassigned liggitt Apr 29, 2020
@liggitt
Copy link
Member

liggitt commented Apr 29, 2020

routing to node reviewers

@bart0sh
Copy link
Contributor Author

bart0sh commented Apr 30, 2020

/assign @derekwaynecarr

@cynepco3hahue
Copy link

lgtm, once we will merge e2e tests #91243 we can merge this one.

@derekwaynecarr
Copy link
Member

I agree that this is ready to promote once #91243 merges, it will need a doc update similar to kubernetes/website#19008

@bart0sh bart0sh mentioned this pull request Jun 5, 2020
Merged
@bart0sh
Copy link
Contributor Author

bart0sh commented Jun 5, 2020

@derekwaynecarr thank you for the review. Documentation update has been submitted: kubernetes/website#21528

@bart0sh
Copy link
Contributor Author

bart0sh commented Jun 12, 2020

/retest

@bart0sh
Copy link
Contributor Author

bart0sh commented Jun 12, 2020

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@cynepco3hahue
Copy link

/retest

@derekwaynecarr
Copy link
Member

/approve

@derekwaynecarr
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2020
@bart0sh bart0sh force-pushed the PR0089-promote-HugePageStorageMediumSize-to-Beta branch from e2df933 to 1540557 Compare June 19, 2020 11:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2020
@bart0sh
Copy link
Contributor Author

bart0sh commented Jun 19, 2020

@derekwaynecarr I had to rebase this due to a conflict with master. Please lgtm again.

@derekwaynecarr
Copy link
Member

e2e failures are unrelated to change.

/retest
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, derekwaynecarr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cynepco3hahue
Copy link

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 21, 2020
@cynepco3hahue
Copy link

/retest

1 similar comment
@cynepco3hahue
Copy link

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 656a01f into kubernetes:master Jun 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 21, 2020
@github-actions github-actions bot mentioned this pull request Jun 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bart0sh @fejta-bot @liggitt @cynepco3hahue @derekwaynecarr @k8s-ci-robot