Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote HugePageStorageMediumSize feature to Beta #21528

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Promote HugePageStorageMediumSize feature to Beta #21528

merged 1 commit into from
Jun 19, 2020

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Jun 5, 2020

This is a documentation update for promoting multiple sizes hugepages future to Beta.

Correspondent k/k PR is here: kubernetes/kubernetes#90592

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 5, 2020
@bart0sh bart0sh mentioned this pull request Jun 5, 2020
Merged
@netlify
Copy link

netlify bot commented Jun 5, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f792810

https://deploy-preview-21528--kubernetes-io-master-staging.netlify.app

sftim
sftim requested changes Jun 6, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bart0sh, can you rebase this against dev-1.19 and then change the PR's base branch? master represents the live website.

@sftim
Copy link
Contributor

sftim commented Jun 6, 2020

/milestone 1.19

@k8s-ci-robot k8s-ci-robot added this to the 1.19 milestone Jun 6, 2020
@bart0sh bart0sh force-pushed the PR0002-multisize-hugepages-beta branch from b5ff628 to f792810 Compare June 8, 2020 09:49
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 8, 2020
@bart0sh bart0sh changed the base branch from master to dev-1.19 June 8, 2020 09:49
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2020
@bart0sh bart0sh requested a review from sftim June 8, 2020 09:50
@sftim
Copy link
Contributor

sftim commented Jun 8, 2020

/remove-language zh

@k8s-ci-robot k8s-ci-robot removed the language/zh Issues or PRs related to Chinese language label Jun 8, 2020
@bart0sh
Copy link
Contributor Author

bart0sh commented Jun 8, 2020

@sftim rebased. Please review again.

sftim
sftim previously requested changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tweak, otherwise this looks good from a Markdown PoV

content/en/docs/reference/command-line-tools-reference/feature-gates.md Show resolved Hide resolved
@bart0sh
Promote HugePageStorageMediumSize feature to Beta
33468aa 
This is a documentation update for promoting
multiple sizes hugepages future to Beta.
@bart0sh bart0sh force-pushed the PR0002-multisize-hugepages-beta branch from f792810 to 33468aa Compare June 8, 2020 11:44
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 33468aa

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5ede248ec41ce40008973870

sftim
sftim reviewed Jun 8, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown looks good to me

@sftim sftim dismissed their stale review June 8, 2020 12:13

Superseded

@jimangel
Copy link
Member

/assign @savitharaghunathan

@derekwaynecarr
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2020
savitharaghunathan
savitharaghunathan reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitharaghunathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit eeeffdb into kubernetes:dev-1.19 Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@savitharaghunathan savitharaghunathan

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.
7 participants
@bart0sh @sftim @k8sio-netlify-preview-bot @jimangel @derekwaynecarr @k8s-ci-robot @savitharaghunathan