Azure: support non-VMSS instances removal

[bpineau]

What type of PR is this?

/kind bug

What this PR does / why we need it:
When called by Controller Manager lifecycle controller for a node missing
heartbeats (via InstanceShutdownByProviderID()), Azure cloud provider
ensures the instance backing that node is shut down or otherwise removed from
its containing VMSS before allowing the node to be reaped from the cluster.

But it won't test the same for VMAS or standalone instances (not part of a
VMSS), which are otherwise well supported: they can register, for instance.
So deleted non-VMSS instances will leave NotReady nodes behind, and,
depending on their name, might cause regular VMSS List / full re-scans.

Which issue(s) this PR fixes:

Fixes #91183

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: support removal of nodes backed by deleted non VMSS instances on Azure

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/kind bug
/assign @andyzhangx @feiskyer
/sig cloud-provider
/area provider/azure

[k8s-ci-robot]

Welcome @bpineau!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bpineau. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andyzhangx]

/ok-to-test

[andyzhangx]

thanks for the contribution!
@bpineau could you fix the ut failure, thanks.

FAIL: TestGetPowerStatusByNodeName (0.00s)
    azure_backoff.go:95: Unexpected call to *mockvmclient.MockInterface.List([context.Background.WithCancel rg]) at staging/src/k8s.io/legacy-cloud-providers/azure/clients/vmclient/mockvmclient/interface.go:71 because: there are no expected calls of the method "List" for that receiver

[feiskyer]

Thanks for the fix

[feiskyer]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpineau, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/legacy-cloud-providers/azure/OWNERS [feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bpineau]

Thanks,
test fixed @andyzhangx
Could this be cherry-picked to 1.18?

[andyzhangx]

/priority important-soon

[andyzhangx]

Thanks,
test fixed @andyzhangx
Could this be cherry-picked to 1.18?

done, #91198
let me try to cherry-pick to other releases.