Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote kubescheduler.config.k8s.io to v1betav1 #91420

Merged
merged 1 commit into from
May 28, 2020
Merged

Promote kubescheduler.config.k8s.io to v1betav1 #91420

merged 1 commit into from
May 28, 2020

Conversation

pancernik
Copy link
Contributor

@pancernik pancernik commented May 25, 2020 •
edited
Loading

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Graduates kubescheduler.config.k8s.io to v1beta1 to promote its wider use.

Which issue(s) this PR fixes:

Part of #89701

Special notes for your reviewer:
Please note that this change is a first step in order to fully promote kubescheduler.config.k8s.io to v1beta1. Improvements and remaining items in #89701 will be added separately.

Does this PR introduce a user-facing change?:

ACTION REQUIRED: upgrade kubescheduler.config.k8s.io/v1alpha2 to kubescheduler.config.k8s.io/v1beta1

- `.bindTimeoutSeconds` was moved as part of plugin args for `VolumeBinding`,
  which can be configured separately per [profile](#profiles).
- `.extenders` are updated to satisfy API standards. In particular:
  - `.extenders` decoding is case sensitive. All fields are affected.
  - `.extenders[*].httpTimeout` is of type `metav1.Duration`.
  - `.extenders[*].enableHttps` is renamed to `.extenders[*].enableHTTPS`.
- `RequestedToCapacityRatio` args decoding is case sensitive. All fields are affected.
- `DefaultPodTopologySpread` [plugin](#scheduling-plugins) is renamed to `SelectorSpread`.
- `Unreserve` extension point is removed from Profile definition. All `Reserve`
  plugins implement an `Unreserve` call.
- `.disablePreemption` was removed. Users can disable preemption by disabling the
  "DefaultPreemption" PostFilter plugin.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP-785: Scheduler Component Config API](https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/785-scheduler-component-config-api#goals)
- [Scheduler configuration](https://kubernetes.io/docs/reference/scheduling/config/)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @pancernik. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 25, 2020
@k8s-ci-robot k8s-ci-robot requested review from damemi and fejta May 25, 2020 20:49
@alculquicondor
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@pancernik
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@pancernik
Copy link
Contributor Author

/assign @lavalamp

@pancernik
Copy link
Contributor Author

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label May 26, 2020
@alculquicondor alculquicondor mentioned this pull request May 26, 2020
Closed
@alculquicondor
Copy link
Member

/approve
from sig scheduling

@damemi damemi mentioned this pull request May 26, 2020
Closed
@alculquicondor
Copy link
Member

/priority important-soon

other contributors are waiting on this change

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 26, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@cofyc
Copy link
Member

cofyc commented May 28, 2020

/retest

3 similar comments
@cofyc
Copy link
Member

cofyc commented May 28, 2020

/retest

@cofyc
Copy link
Member

cofyc commented May 28, 2020

/retest

@cofyc
Copy link
Member

cofyc commented May 28, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@pancernik
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@pancernik
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce-big

@alculquicondor alculquicondor mentioned this pull request May 28, 2020
Closed
@k8s-ci-robot k8s-ci-robot merged commit c682b31 into kubernetes:master May 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 28, 2020
@alculquicondor alculquicondor mentioned this pull request May 28, 2020
Closed
2 tasks
@hakman hakman mentioned this pull request May 29, 2020
Merged
@github-actions github-actions bot mentioned this pull request Jun 2, 2020
Open
@alculquicondor
Copy link
Member

@pancernik please update release note to:

ACTION REQUIRED: upgrade kubescheduler.config.k8s.io/v1alpha2 to kubescheduler.config.k8s.io/v1beta1

@alculquicondor
Copy link
Member

also, once kubernetes/website#21437 lands, we will update the release note to point to the new website page.

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 5, 2020
@damemi damemi mentioned this pull request Jun 22, 2020
Merged
@pancernik pancernik mentioned this pull request Jul 3, 2020
Closed
6 tasks
@alculquicondor alculquicondor mentioned this pull request Jul 13, 2020
Merged
@rfranzke rfranzke mentioned this pull request Aug 17, 2020
Closed
rfranzke added a commit to gardener/gardener that referenced this pull request Aug 28, 2020
@rfranzke
Update API versions for 1.19
90d6bdd 
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
rfranzke added a commit to gardener/gardener that referenced this pull request Aug 31, 2020
@rfranzke
Update API versions for 1.19
042d208 
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
rfranzke added a commit to gardener/gardener that referenced this pull request Sep 1, 2020
@rfranzke
Update API versions for 1.19
a284d73 
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

@fejta fejta Awaiting requested review from fejta

Assignees

@lavalamp lavalamp

@damemi damemi

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pancernik @k8s-ci-robot @alculquicondor @fejta-bot @lavalamp @ahg-g @cofyc @damemi