Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress: Add CRUD tests for Ingress API verbs #91593

Merged
merged 1 commit into from Jun 11, 2020
Merged

ingress: Add CRUD tests for Ingress API verbs #91593

merged 1 commit into from Jun 11, 2020

Conversation

cmluciano
Copy link

@cmluciano cmluciano commented May 29, 2020 •
edited by liggitt

What type of PR is this?
/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes:
xref: kubernetes/enhancements#1453

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 29, 2020
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels May 29, 2020
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 29, 2020
@kow3ns
Copy link
Member

kow3ns commented Jun 1, 2020

/remove-sig apps

@k8s-ci-robot k8s-ci-robot removed the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jun 1, 2020
@cmluciano cmluciano marked this pull request as ready for review June 1, 2020 17:40
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2020
@cmluciano
Copy link
Author

/cc @liggitt @robscott

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jun 1, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

liggitt
liggitt reviewed Jun 1, 2020
View reviewed changes
test/e2e/network/ingress.go Outdated Show resolved Hide resolved
@liggitt
Copy link
Member

liggitt commented Jun 1, 2020

I think the Add CRUD tests for Ingress API verbs commit can be rebased on master and go ahead and merge, correct?

@cmluciano
Copy link
Author

/retest

1 similar comment
@cmluciano
Copy link
Author

/retest

liggitt
liggitt reviewed Jun 8, 2020
View reviewed changes
test/e2e/network/ingress.go Outdated Show resolved Hide resolved
liggitt
liggitt reviewed Jun 8, 2020
View reviewed changes
test/e2e/network/ingress.go Outdated Show resolved Hide resolved
liggitt
liggitt reviewed Jun 8, 2020
View reviewed changes
test/e2e/network/ingress.go Outdated Show resolved Hide resolved
liggitt
liggitt reviewed Jun 8, 2020
View reviewed changes
test/e2e/network/ingress.go Outdated Show resolved Hide resolved
liggitt
liggitt reviewed Jun 8, 2020
View reviewed changes
test/e2e/network/ingress.go Outdated Show resolved Hide resolved
@liggitt
Copy link
Member

liggitt commented Jun 8, 2020

one question about the pathtype/path, one comment about filtering lists correctly, and a couple nits, then lgtm

@cmluciano cmluciano force-pushed the cml/conformancev1ing branch 3 times, most recently from 1f94439 to c714a3e Compare June 9, 2020 19:22
@liggitt liggitt mentioned this pull request Jun 9, 2020
Merged
2 tasks
@cmluciano
Copy link
Author

/retest

liggitt
liggitt reviewed Jun 9, 2020
View reviewed changes
test/e2e/network/ingress.go Outdated Show resolved Hide resolved
liggitt
liggitt reviewed Jun 9, 2020
View reviewed changes
test/e2e/network/ingress.go Outdated Show resolved Hide resolved
test/e2e/network/ingress.go Outdated Show resolved Hide resolved
test/e2e/network/ingress.go Outdated Show resolved Hide resolved
test/e2e/network/ingress.go Outdated Show resolved Hide resolved
@cmluciano
Copy link
Author

/retest

@cmluciano cmluciano mentioned this pull request Jun 10, 2020
Merged
2 tasks
ingress: Add CRUD tests for Ingress API verbs
7351330 
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
@liggitt
Copy link
Member

liggitt commented Jun 11, 2020

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmluciano, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit b8369fd into kubernetes:master Jun 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 11, 2020
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@danwinship danwinship Awaiting requested review from danwinship

@robscott robscott Awaiting requested review from robscott

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cmluciano @k8s-ci-robot @kow3ns @fejta-bot @liggitt @robscott