Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #91008: Do not swallow NotFound error for DeletePod in dsc.manage #91988

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Automated cherry pick of #91008: Do not swallow NotFound error for DeletePod in dsc.manage #91988

merged 1 commit into from
Sep 11, 2020

Conversation

249043822
Copy link
Member

Cherry pick of #91008 on release-1.17.

#91008: Do not swallow NotFound error for DeletePod in dsc.manage

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Jun 10, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @249043822. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Jun 10, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 10, 2020
@tpepper
Copy link
Member

tpepper commented Jun 11, 2020

/kind bug
/priority important-soon
/ok-to-test
/release-note-none

@249043822 thank you for this!

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 11, 2020
@249043822
Copy link
Member Author

/assign @tpepper @soltysh @tnozicka

@249043822
Copy link
Member Author

/assign @tpepper @soltysh @tnozicka

soltysh
soltysh approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2020
@249043822
Copy link
Member Author

@tpepper @soltysh @tnozicka will this cherry-pick be merged？

@cpanato
Copy link
Member

cpanato commented Aug 21, 2020

can you please take a look on this PR @deads2k thanks!

@tpepper
Copy link
Member

tpepper commented Sep 3, 2020

Needs approval from an approver in each of these files:

From that file we see we need one of
approvers:

@tpepper
Copy link
Member

tpepper commented Sep 3, 2020

/assign @deads2k
/assign @derekwaynecarr
/assign @mikedanese
/assign @janetkuo

@janetkuo
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 249043822, janetkuo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 11, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit f8906d5 into kubernetes:release-1.17 Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@janetkuo janetkuo janetkuo approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@kow3ns kow3ns Awaiting requested review from kow3ns

Assignees

@soltysh soltysh

@mikedanese mikedanese

@tpepper tpepper

@janetkuo janetkuo

@derekwaynecarr derekwaynecarr

@deads2k deads2k

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
10 participants
@249043822 @k8s-ci-robot @tpepper @cpanato @janetkuo @soltysh @mikedanese @derekwaynecarr @deads2k @tnozicka