Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include CSIDriver capability to indicate fsGroup support #92001

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Include CSIDriver capability to indicate fsGroup support #92001

merged 4 commits into from
Jul 16, 2020

Conversation

huffmanca
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR is the followup to https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1682-csi-driver-skip-permission , and introduces the SupportsFsGroup field for CSIDrivers. This allows CSIDrivers to declare if they wish to allow modifying the fsGroup when volumes are mounted.

Which issue(s) this PR fixes:
Fixes kubernetes/enhancements#1682

Special notes for your reviewer:
I've currently added the field in the v1 and v1beta1 staging APIs; however, this should be an alpha field on the CSIDriver.Spec object. I noticed another field (InlineVolumeSpec) that includes a comment mentioning it's alpha-level.

What's the correct way to include this?

Does this PR introduce a user-facing change?:

A new alpha-level field, `SupportsFsGroup`, has been introduced for CSIDrivers to allow them to specify whether they support volume ownership and permission modifications. The `CSIVolumeSupportFSGroup` feature gate must be enabled to allow this field to be used.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1682-csi-driver-skip-permission
- TODO: Include docs PR

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/kubectl kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 10, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@huffmanca huffmanca mentioned this pull request Jun 11, 2020
Closed
@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 11, 2020
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 15, 2020
jsafrane
jsafrane reviewed Jun 18, 2020
View reviewed changes
pkg/apis/storage/types.go Outdated Show resolved Hide resolved
pkg/apis/storage/types.go Outdated Show resolved Hide resolved
@huffmanca huffmanca force-pushed the include-csidriver-fsgroup branch 5 times, most recently from daee349 to 46b925c Compare June 22, 2020 14:21
@msau42
Copy link
Member

msau42 commented Jul 13, 2020

/lgtm
rebased

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@huffmanca
Copy link
Contributor Author

/test pull-kubernetes-verify

@huffmanca
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@huffmanca
Copy link
Contributor Author

/retest

@huffmanca
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@huffmanca
Copy link
Contributor Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@msau42
Copy link
Member

msau42 commented Jul 15, 2020

/retest

5 similar comments
@huffmanca
Copy link
Contributor Author

/retest

@huffmanca
Copy link
Contributor Author

/retest

@huffmanca
Copy link
Contributor Author

/retest

@msau42
Copy link
Member

msau42 commented Jul 15, 2020

/retest

@huffmanca
Copy link
Contributor Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@huffmanca
Copy link
Contributor Author

/test pull-kubernetes-integration

@huffmanca
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit 96c057a into kubernetes:master Jul 16, 2020
@huffmanca huffmanca mentioned this pull request Jul 17, 2020
Merged
@liggitt
Copy link
Member

liggitt commented Jul 18, 2020 •
edited
Loading

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/92001/pull-kubernetes-node-e2e/1283589292660101120, https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/92001/pull-kubernetes-node-e2e/1283173804738088960, and https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/92001/pull-kubernetes-node-e2e/1283388533867810816 flakes were #93210

@github-actions github-actions bot mentioned this pull request Jul 22, 2020
Open
@huffmanca huffmanca mentioned this pull request Oct 28, 2020
Closed
6 tasks
@jingxu97 jingxu97 mentioned this pull request Nov 13, 2020
Merged
@saad-ali saad-ali mentioned this pull request Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@jsafrane jsafrane jsafrane left review comments

@msau42 msau42 msau42 left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@nikhiljindal nikhiljindal Awaiting requested review from nikhiljindal

Assignees

@smarterclayton smarterclayton

@msau42 msau42

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Allow CSI drivers to opt-in to volume ownership change
10 participants
@huffmanca @fejta-bot @fedebongio @msau42 @gnufied @smarterclayton @k8s-ci-robot @liggitt @jsafrane @saad-ali