-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move external facing podresources apis to staging #92632
Move external facing podresources apis to staging #92632
Conversation
d2089f7
to
b0a6b92
Compare
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
b0a6b92
to
a8cb25a
Compare
/label api-review |
/assign @dashpole |
a8cb25a
to
9419692
Compare
/retest |
/lgtm Thanks @RenaudWasTaken |
/priority important-soon |
please see this PR merge policy change. the milestone should be applied later in the cycle. thanks |
I'll probably wait a bit that regular maintenance restarts before rebasing this PR :) ! |
@RenaudWasTaken this time came =) It's now in 1.20 milestone |
Will take care of it this week then! |
9419692
to
fc9ffb0
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, liggitt, RenaudWasTaken The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fc9ffb0
to
0e69639
Compare
0e69639
to
7e65c26
Compare
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
7e65c26
to
27fd6fd
Compare
27fd6fd
to
4eadf40
Compare
/retest |
/lgtm |
What type of PR is this?
/kind api-change
/area code-organization
/sig node
What this PR does / why we need it:
podresources API is external facing. Currently we are forcing folks to import them from k8s.io/kubernetes which is not optimal. We should instead make them available from the k8s.io/kubelet repo to make it easier for them.
Which issue(s) this PR fixes: N/A
Special notes for your reviewer:
Note, for people who will be broken by this change (i.e: people pulling from kubernetes master), they can either:
a) Freeze the kubernetes version they rely on, which they already should, in the go.mod they should have something along the lines of
b) Change the import path:
/cc @dashpole @derekwaynecarr
Enhancement issue: kubernetes/enhancements#606
Current Kep: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/compute-device-assignment.md
Updated Kep: kubernetes/enhancements#1865
Note: Change is targeting current milestone and we expect to introduce v1 in the next release.
Also note that despite the API name, it is currently in beta (since 1.15).
Does this PR introduce a user-facing change?: