Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 3rd party device monitoring plugins #606

Closed
dashpole opened this issue Jul 31, 2018 · 88 comments · Fixed by kubernetes/kubernetes#92165
Closed

Support 3rd party device monitoring plugins #606

dashpole opened this issue Jul 31, 2018 · 88 comments · Fixed by kubernetes/kubernetes#92165
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@dashpole
Copy link
Contributor

dashpole commented Jul 31, 2018

Feature Description

  1. As a cluster admin, I want container-level metrics for devices provided by device plugins.
  2. As a device vendor, I want to be able to provide device-specific metrics without contributing to core kubernetes.
  • One-line feature description (can be used as a release note): Support 3rd party device monitoring plugins
  • Primary contact (assignee): @dashpole
  • Responsible SIGs: sig-node
  • Design proposal link (community repo): KEP: Support Device Monitoring community#2454
  • KEP: 606-compute-device-assignment
  • Link to e2e and/or unit tests: Coming Soon
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @vikaschoudhary16 @jiayingz
  • Approver (likely from SIG/area to which feature belongs): @derekwaynecarr
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.13)
    • Beta release target (1.15)
    • Stable release target (1.20)

/kind feature
/sig node

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jul 31, 2018
@kacole2
Copy link
Member

kacole2 commented Jul 31, 2018

@dashpole this has been added to the 1.12 tracking sheet. Thank you

@justaugustus please add relevant tags to this issue

@justaugustus justaugustus added this to the v1.12 milestone Jul 31, 2018
@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 31, 2018
@justaugustus
Copy link
Member

justaugustus commented Jul 31, 2018

@kacole2 all set!

@vikaschoudhary16
Copy link
Member

vikaschoudhary16 commented Aug 1, 2018

@dashpole looks like design proposal link should be this one: https://docs.google.com/document/d/1NYnqw-HDQ6Y3L_mk85Q3wkxDtGNWTxpsedsgw4NgWpg/edit

@dashpole
Copy link
Contributor Author

dashpole commented Aug 1, 2018

Agreed, that makes more sense

@justaugustus
Copy link
Member

justaugustus commented Aug 15, 2018

/assign @dashpole

@zparnold
Copy link
Member

zparnold commented Aug 20, 2018

Hey there! @dashpole I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@dashpole
Copy link
Contributor Author

dashpole commented Aug 20, 2018

@zparnold here is the docs pr placeholder: kubernetes/website#9945

@zparnold
Copy link
Member

zparnold commented Aug 25, 2018

Thank you @dashpole!

@justaugustus
Copy link
Member

justaugustus commented Sep 5, 2018

@dashpole --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@dashpole
Copy link
Contributor Author

dashpole commented Sep 5, 2018

It can be removed from the milestone

@justaugustus
Copy link
Member

justaugustus commented Sep 5, 2018

Got it. Thanks for the update!

@justaugustus justaugustus added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 5, 2018
@justaugustus justaugustus removed this from the v1.12 milestone Sep 5, 2018
@kacole2
Copy link
Member

kacole2 commented Oct 8, 2018

Hi @dashpole
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. I can see that your original post says Alpha for 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to ping @kacole2 so it can be included in the 1.13 Enhancements Tracking Sheet if it's going to make it.

Thanks!

@kacole2
Copy link
Member

kacole2 commented Oct 8, 2018

/milestone v1.13
/tracked yes

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 8, 2018
@kacole2 kacole2 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 8, 2018
@AishSundar
Copy link

AishSundar commented Oct 17, 2018

@dashpole could you please let us know whats pending for this feature to go to Alpha in 1.13. Do you have a list of pending PRs or issues you can point us to. Thanks

@claurence
Copy link

claurence commented Oct 22, 2018

@dashpole there has been no communication on the status. Are we confident this is going to make the v1.13 milestone? Enhancement freeze is tomorrow COB. If there is no communication or update on the PR, this is going to be pulled from the milestone as it doesn't fit with our "stability" theme. If there is no communication after COB tomorrow, an exception will be required to add it back to the milestone. Please let me know where we stand. Thanks!

@dashpole
Copy link
Contributor Author

dashpole commented Oct 22, 2018

KEP: kubernetes/community#2454 should be merged soon, as it is approved by the required people. Once that happens, Ill open the implementation PR, and get working on docs. I still expect this to land in 1.13.

@palnabarun
Copy link
Member

palnabarun commented Sep 1, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020
@palnabarun
Copy link
Member

palnabarun commented Sep 1, 2020

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 1, 2020
@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 12, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 23, 2020

Hi @RenaudWasTaken

Enhancements Lead here. I see that you are targetting GA for 1.20, as a reminder 1.20 Enhancements Freeze is October 6th. To be included in the milestone:

  • The KEP must be merged in an implementable state
  • The KEP must have test plans (missing)
  • The KEP must have graduation criteria (missing)

The current KEP is missing Test Plans and Graduation Criteria. Could you please update to use the new format which contains both sections? See for ref https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Thanks,
Kirsten

@kinarashah
Copy link

kinarashah commented Sep 29, 2020

Hi @RenaudWasTaken,

Enhancement shadow for 1.20 release here 👋 . As we're moving closer to the Enhancement Freeze deadline (October 6), just wanted to remind you to update your KEP with

  • Test plans
  • Graduation criteria

Please note that these are required for the enhancement to be tracked for 1.20 milestone.

Thank you!

@RenaudWasTaken
Copy link
Member

RenaudWasTaken commented Sep 29, 2020

Sorry for the delay, will take a stab at it tomorrow

@RenaudWasTaken
Copy link
Member

RenaudWasTaken commented Sep 30, 2020

Updated the standing PR here: #1865
Will look to get approval on it from sig-node this week and at next week's meeting!

@kinarashah
Copy link

kinarashah commented Oct 11, 2020

Hi @RenaudWasTaken,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you!

@annajung
Copy link
Member

annajung commented Oct 16, 2020

Hello @RenaudWasTaken 👋 , 1.20 Docs lead here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@RenaudWasTaken
Copy link
Member

RenaudWasTaken commented Oct 27, 2020

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

I'm not sure we will be updating the docs for v1.
We don't plan on updating the docs for v1, let me know if you think we need to change them.

Right now, we are in the review of the graduation PR: kubernetes/kubernetes#92165

@RenaudWasTaken
Copy link
Member

RenaudWasTaken commented Oct 27, 2020

Thinking about it a bit more, we need to update the reference out of beta, let me do that

@annajung
Copy link
Member

annajung commented Nov 1, 2020

Hi @RenaudWasTaken

Thanks for creating the docs PR!

Please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 11, 2020

Reopened as it was auto-closed but need to keep it open for tracking until the end of the release.

Just to confirm: @RenaudWasTaken This is now finished correct?

@RenaudWasTaken
Copy link
Member

RenaudWasTaken commented Nov 11, 2020

The base feature is, there are other features built on top that have their own tracking issue :) !

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Dec 10, 2020

Hi @RenaudWasTaken

Could you update the kep.yaml to reflect a status of implemented:

After that merges you can close this issue :)

Thanks,
Kirsten

@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 7, 2021
@annajung
Copy link
Member

annajung commented Jan 7, 2021

This issue is still waiting on #2177 before closing.

@annajung
Copy link
Member

annajung commented Jan 26, 2021

Hello, I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 26, 2021

@annajung: Closing this issue.

In response to this:

Hello, I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

Successfully merging a pull request may close this issue.