Support 3rd party device monitoring plugins

[dashpole]

Feature Description

1. As a cluster admin, I want container-level metrics for devices provided by device plugins.
2. As a device vendor, I want to be able to provide device-specific metrics without contributing to core kubernetes.

• One-line feature description (can be used as a release note): Support 3rd party device monitoring plugins

• Primary contact (assignee): @ffromani

• Responsible SIGs: sig-node

• Design proposal link (community repo): KEP: Support Device Monitoring community#2454

• KEP: 606-compute-device-assignment

• Link to e2e and/or unit tests: Coming Soon

• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @vikaschoudhary16 @jiayingz

• Approver (likely from SIG/area to which feature belongs): @derekwaynecarr

• Feature target (which target equals to which milestone):

  • Alpha release target (1.13)
  • Beta release target (1.15)
  • Stable release target (1.20)

• Stable

  • KEP (k/enhancements) update PR(s):
    • KEP-606: finalize podresources API GA graduation #3791
  • Code (k/k) update PR(s):
    • node: create podresources endpoint also on windows kubernetes#115133
  • Docs (k/website) update(s):
    • WIP: node: graduate the podresources API endpoint to GA website#39959

/kind feature
/sig node

[kacole2]

@dashpole this has been added to the 1.12 tracking sheet. Thank you

@justaugustus please add relevant tags to this issue

[justaugustus]

@kacole2 all set!

[vikaschoudhary16]

@dashpole looks like design proposal link should be this one: https://docs.google.com/document/d/1NYnqw-HDQ6Y3L_mk85Q3wkxDtGNWTxpsedsgw4NgWpg/edit

[dashpole]

Agreed, that makes more sense

[justaugustus]

/assign @dashpole

[zparnold]

Hey there! @dashpole I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[dashpole]

@zparnold here is the docs pr placeholder: kubernetes/website#9945

[zparnold]

Thank you @dashpole!

[justaugustus]

@dashpole --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

[dashpole]

It can be removed from the milestone

[justaugustus]

Got it. Thanks for the update!

[kacole2]

Hi @dashpole
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. I can see that your original post says Alpha for 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to ping @kacole2 so it can be included in the 1.13 Enhancements Tracking Sheet if it's going to make it.

Thanks!

[kacole2]

/milestone v1.13
/tracked yes

[AishSundar]

@dashpole could you please let us know whats pending for this feature to go to Alpha in 1.13. Do you have a list of pending PRs or issues you can point us to. Thanks

[claurence]

@dashpole there has been no communication on the status. Are we confident this is going to make the v1.13 milestone? Enhancement freeze is tomorrow COB. If there is no communication or update on the PR, this is going to be pulled from the milestone as it doesn't fit with our "stability" theme. If there is no communication after COB tomorrow, an exception will be required to add it back to the milestone. Please let me know where we stand. Thanks!

[dashpole]

KEP: kubernetes/community#2454 should be merged soon, as it is approved by the required people. Once that happens, Ill open the implementation PR, and get working on docs. I still expect this to land in 1.13.

[RenaudWasTaken]

The base feature is, there are other features built on top that have their own tracking issue :) !

[kikisdeliveryservice]

Hi @RenaudWasTaken

Could you update the kep.yaml to reflect a status of implemented:

enhancements/keps/sig-node/606-compute-device-assignment/kep.yaml

Line 9 in f40c24a

status: implementable

After that merges you can close this issue :)

Thanks,
Kirsten

[annajung]

This issue is still waiting on #2177 before closing.

[annajung]

Hello, I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

[k8s-ci-robot]

@annajung: Closing this issue.

In response to this:

Hello, I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ffromani]

Some more work is needed to be able to lock the feature gate (https://groups.google.com/g/kubernetes-sig-architecture/c/v4OwOaBkvVc/m/xdfLryLTGQAJ)
so:

Enhancement Description

• One-line enhancement description (can be used as a release note): promote to GA the kubelet podresources API endpoint
• Kubernetes Enhancement Proposal: TODO
• Discussion Link: SIG Node - 1.27 Planning discussed on SIG Node weekly on [13th December 2023]
• Primary contact (assignee): @ffromani
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.13
  • Beta release target (x.y): 1.15
  • Stable release target (x.y): 1.27
• Stable
  • KEP (k/enhancements) update PR(s): KEP-606: finalize podresources API GA graduation #3791
  • Code (k/k) update PR(s):
    • node: create podresources endpoint also on windows kubernetes#115133
  • Docs (k/website) update(s): TODO

[ffromani]

/reopen

[k8s-ci-robot]

@ffromani: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[SergeyKanzhelev]

/milestone v1.27

@ffromani I think you still plan to make it happen, correct?

[SergeyKanzhelev]

/label lead-opted-in

Not sure if this is also tracked by #3743

Adding all labels just in case. @ffromani please close this one if not needed any longer

[ffromani]

/label lead-opted-in

Not sure if this is also tracked by #3743

Adding all labels just in case. @ffromani please close this one if not needed any longer

yes, absolutely.
Due to dependencies it can slip to 1.28 but I'm 100% committed to work on this in the 1.27 cycle.

[marosset]

Hello @ffromani 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.27
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like #3791 will address the remaining requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you!

[marosset]

This enhancement meets all the requirements to be included in v1.27 and is now tracked for the release.

Thanks @ffromani!

[Rishit-dagli]

Hi @dashpole 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.
Please feel free to reach out with any questions. Thanks!

[shatoboar]

Hi @dashpole 👋,
Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.
Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

• node: create podresources endpoint also on windows kubernetes#115133

Please let me know what other PRs in k/k I should be tracking for this KEP.
As always, we are here to help should questions come up. Thanks!

[marosset]

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear
/remove-label tracked/yes
/label tracked/no

[ffromani]

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

no problem. Deferring to 1.28 is not a big deal. We made good progress on GA blockers. I'll be working to merge kubernetes/kubernetes#115133 as early as possible and we should have a much easier path to GA this work in 1.28.