-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kubectl describe ingress
format
#94985
Conversation
Fixes kubernetes#94980 Fixes two formatting issues: * Un-opened parenthesis (`10.244.0.6:8080)`) * Bad format string and spacing Before this PR: ``` Name: example-ingress Namespace: default Address: Default backend: istio-ingressgateway:80 (<error: endpoints "istio-ingressgateway" not found>) Rules: Host Path Backends ---- ---- -------- * * %!(EXTRA string=istio-ingressgateway:80 (<error: endpoints "istio-ingressgateway" not found>))Annotations: <none> Events: <none> ``` After this PR: ``` Name: example-ingress Namespace: default Address: Default backend: istio-ingressgateway:80 (<error: endpoints "istio-ingressgateway" not found>) Rules: Host Path Backends ---- ---- -------- * * istio-ingressgateway:80 (<error: endpoints "istio-ingressgateway" not found>) Annotations: <none> Events: <none> ``` Compare to an old kubectl without the bug: ``` Name: example-ingress Namespace: default Address: Default backend: istio-ingressgateway:80 (<none>) Rules: Host Path Backends ---- ---- -------- * * istio-ingressgateway:80 (<none>) Annotations: kubectl.kubernetes.io/last-applied-configuration: ... Events: <none> ```
Hi @howardjohn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @robscott @cmluciano |
Thanks for catching this! Do you mind adding a release note since I think this would qualify as a user facing change? Otherwise LGTM. /kind bug |
/remove-priority backlog |
/sig network |
@robscott thanks, added a note |
/uncc |
Thanks! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These strings changes can get so messy :( thanks for the fix
I'm uncertain if kubectl changes are backported to earlier k8s releases or not, but we might want to cherry-pick against 1.19 once this is merged.
/lgtm
we should pick this to 1.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
1.19 pick in #95591 |
…5-upstream-release-1.19 Automated cherry pick of #94985: Fix `kubectl describe ingress` format
Fixes #94980
Fixes two formatting issues:
10.244.0.6:8080)
)Before this PR:
After this PR:
Compare to an old kubectl without the bug:
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #94980
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: