Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #92614: Don't create a new sandbox for pod with #95508

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Automated cherry pick of #92614: Don't create a new sandbox for pod with #95508

merged 1 commit into from
Nov 27, 2020

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Oct 13, 2020

Cherry pick of #92614 on release-1.17.

#92614: Don't create a new sandbox for pod with

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 13, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 13, 2020
@tnqn tnqn mentioned this pull request Oct 13, 2020
Merged
@tnqn
Don't create a new sandbox for pod with RestartPolicyOnFailure if all…
085d9ed 
… containers succeeded

The kubelet would attempt to create a new sandbox for a pod whose
RestartPolicy is OnFailure even after all container succeeded. It caused
unnecessary CRI and CNI calls, confusing logs and conflicts between the
routine that creates the new sandbox and the routine that kills the Pod.

This patch checks the containers to start and stops creating sandbox if
no container is supposed to start.
@tnqn tnqn force-pushed the automated-cherry-pick-of-#92614-upstream-release-1.17 branch from 3439ea8 to 085d9ed Compare October 13, 2020 06:50
@SergeyKanzhelev
Copy link
Member

/kind bug
/lgtm

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 14, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2020
@cpanato
Copy link
Member

cpanato commented Oct 20, 2020

from parent PR
/kind bug

@cpanato
Copy link
Member

cpanato commented Oct 20, 2020

@dchen1107 can you review this PR as well since you approved the other 2 prs for another release branches?
thanks!

@alex-vmw
Copy link

@SergeyKanzhelev @dashpole @dims Can you please approve/merge this for 1.17.14?

@dashpole
Copy link
Contributor

/approve

@alex-vmw
Copy link

/assign @derekwaynecarr

@alex-vmw
Copy link

@puerco @gianarb @jimangel @markyjackson-taulia @mkorbi @onlydole @saschagrunert Could we please get a cherry-pick review and merge this into 1.17.14 now that it is approved?

P.S. This is already merged into 1.19.4 as per #94725.

@cpanato
Copy link
Member

cpanato commented Oct 23, 2020

@alex-mohr dont need to ping everybody

@cpanato
Copy link
Member

cpanato commented Oct 23, 2020

@dashpole / @dchen1107 can you please review this PR as well since you both reviewed #94959 ? thanks!

@SergeyKanzhelev
Copy link
Member

Could we please get a cherry-pick review and merge this into 1.17.14 now that it is approved?

It's not approved yet. Somebody from this list need to approve:

kubernetes/test/e2e/node/OWNERS

Lines 4 to 7 in 54f3c09

- Random-Liu
- derekwaynecarr
- tallclair
- yujuhong

@alex-vmw
Copy link

Could we please get a cherry-pick review and merge this into 1.17.14 now that it is approved?

It's not approved yet. Somebody from this list need to approve:

kubernetes/test/e2e/node/OWNERS

Lines 4 to 7 in 54f3c09

- Random-Liu
- derekwaynecarr
- tallclair
- yujuhong

@SergeyKanzhelev Sorry, you are absolutely correct. The joys of trying to approve 3 identical pull requests for 3 different k8s branches; easy to get confused.

@SergeyKanzhelev
Copy link
Member

The joys of trying to approve 3 identical pull requests for 3 different k8s branches; easy to get confused.

I hear you. @derekwaynecarr is typically bulk approve things on Monday or Tuesday before the SIG node meeting.

@cpanato
Copy link
Member

cpanato commented Nov 5, 2020

@dchen1107 can you review this cherry pick since you reviewed #94959
thanks

1 similar comment
@cpanato
Copy link
Member

cpanato commented Nov 5, 2020

@dchen1107 can you review this cherry pick since you reviewed #94959
thanks

@derekwaynecarr
Copy link
Member

1.18 pick has been approved but not yet merged.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020
@cpanato
Copy link
Member

cpanato commented Nov 27, 2020

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 27, 2020
cpanato
cpanato approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 27, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dashpole, derekwaynecarr, tnqn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 64a9540 into kubernetes:release-1.17 Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@krmayankk krmayankk Awaiting requested review from krmayankk

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

Assignees

@cpanato cpanato

@derekwaynecarr derekwaynecarr

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
7 participants
@tnqn @SergeyKanzhelev @cpanato @alex-vmw @dashpole @derekwaynecarr @k8s-ci-robot